-
Notifications
You must be signed in to change notification settings - Fork 39
fix: add smoking policy radio #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!! Works perfectly.
I know this wasn't in the ticket, but showed it to Em, would we be able to just swap Services offered with Smoking policy regardless of the toggle value, so that in the case the toggle is on, the radio breaks up the text areas just a wee bit less?
Other than that looks good to merge!
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This PR addresses #5677
Description
Adds
enableSmokingPolicyRadioflag that adds radio instead of textfield for smoking policyHow Can This Be Tested/Reviewed?
On Angelopolis add / edit new listing it should have
Policy unknownas default selected. Now we should be able to switch that and see it on details page, and public page. I assumed thatPolicy unknownjust won't show that section on public, as it worked before fornull(not sure if that is correct).For csv export it will export as
Policy unknownjust when all jurisdiction have flag onAuthor Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: