Skip to content

Conversation

@KrissDrawing
Copy link
Collaborator

This PR addresses #5677

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds enableSmokingPolicyRadio flag that adds radio instead of textfield for smoking policy

How Can This Be Tested/Reviewed?

On Angelopolis add / edit new listing it should have Policy unknown as default selected. Now we should be able to switch that and see it on details page, and public page. I assumed that Policy unknown just won't show that section on public, as it worked before for null (not sure if that is correct).
For csv export it will export as Policy unknown just when all jurisdiction have flag on

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Dec 15, 2025
@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit ae7f12f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/69403e4bffa0090008c62a95
😎 Deploy Preview https://deploy-preview-5694--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit ae7f12f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69403e4ba536870007b3cb5c
😎 Deploy Preview https://deploy-preview-5694--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit ae7f12f
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69403e4be509680008486cbb
😎 Deploy Preview https://deploy-preview-5694--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit ae7f12f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/69403e4b7e66350008187ce5
😎 Deploy Preview https://deploy-preview-5694--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit ae7f12f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/69403e4b3b1417000829496e
😎 Deploy Preview https://deploy-preview-5694--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit ae7f12f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/69403e4bc772860008e20a60
😎 Deploy Preview https://deploy-preview-5694--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!! Works perfectly.

I know this wasn't in the ticket, but showed it to Em, would we be able to just swap Services offered with Smoking policy regardless of the toggle value, so that in the case the toggle is on, the radio breaks up the text areas just a wee bit less?

Other than that looks good to merge!

Image

@emilyjablonski emilyjablonski removed the 1 review needed Requires 1 more review before ready to merge label Dec 24, 2025
@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit c96e879
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6953e71eed7c7e000878c279
😎 Deploy Preview https://deploy-preview-5694--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit c96e879
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6953e71f33aa620008a0d98e
😎 Deploy Preview https://deploy-preview-5694--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit c96e879
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/6953e71eb8a31f0007d005d0
😎 Deploy Preview https://deploy-preview-5694--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit c96e879
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6953e71ece4e1e0008fc64e7
😎 Deploy Preview https://deploy-preview-5694--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit c96e879
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6953e71ee649720008265210
😎 Deploy Preview https://deploy-preview-5694--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit c96e879
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/6953e71e5ec4b200086e947c
😎 Deploy Preview https://deploy-preview-5694--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants