Skip to content

fix: hide closed listings from crawlers #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludtkemorgan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: hide closed listings from crawlers #5400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a866f03
fix: hide closed and draft listings from crawlers
ludtkemorgan Sep 30, 2025
ba704a6
fix: switch to just closed listings
ludtkemorgan Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sites/public/src/layouts/application.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ interface LayoutProps {
children: React.ReactNode
metaDescription?: string
metaImage?: string
noIndex?: boolean
pageTitle?: string
}

Expand Down Expand Up @@ -231,6 +232,7 @@ const Layout = (props: LayoutProps) => {
<title>
{props.pageTitle ? `${props.pageTitle} - ${t("nav.siteTitle")}` : t("nav.siteTitle")}
</title>
{props.noIndex && <meta name="robots" content="noindex, follow" />}
{props.pageTitle && (
<MetaTags
title={props.pageTitle}
Expand Down
14 changes: 12 additions & 2 deletions sites/public/src/pages/listing/[id]/[slug].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ import { ListingView } from "../../../components/listing/ListingView"
import { ErrorPage } from "../../_error"
import dayjs from "dayjs"
import { fetchJurisdictionByName } from "../../../lib/hooks"
import { Jurisdiction, Listing } from "@bloom-housing/shared-helpers/src/types/backend-swagger"
import {
Jurisdiction,
Listing,
ListingsStatusEnum,
} from "@bloom-housing/shared-helpers/src/types/backend-swagger"
import { ListingViewSeeds } from "../../../components/listing/ListingViewSeeds"

interface ListingProps {
Expand Down Expand Up @@ -64,7 +68,13 @@ export default function ListingPage(props: ListingProps) {
const metaImage = imageUrlFromListing(listing, parseInt(process.env.listingPhotoSize))[0]

return (
<Layout pageTitle={listing.name} metaImage={metaImage} metaDescription={metaDescription}>
<Layout
pageTitle={listing.name}
metaImage={metaImage}
metaDescription={metaDescription}
// search engines should not crawl for closed listings
noIndex={listing.status === ListingsStatusEnum.closed}
>
{process.env.showNewSeedsDesigns ? (
<ListingViewSeeds listing={listing} profile={profile} jurisdiction={props.jurisdiction} />
) : (
Expand Down