Skip to content

Conversation

@ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Sep 30, 2025

This PR addresses metrotranscom#1438

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

When searching for a listing on google non-open listings can be shown. This is not ideal if a listing is still in draft or a listing has been duplicated and the older posting is showing higher in the search results.

Since it can be a long time between google picking up a change from the meta tags it has been determined to only add this to the closed listings as those should normally not be re-opened whereas a draft listing could become open at any time

How Can This Be Tested/Reviewed?

You can't test if this will prevent search crawlers from finding the page, but you can verify that the listing details page is adding the "meta" tag on closedlistings.

  1. Go to the /listings/[id] page of an open listing. You should not see the new meta tag in the
  2. Go to the /listings/[id] page of a closed listing. You should see the new meta tag in the
  3. Go to the /listings/[id] page of a draft listing. You should not see the new meta tag in the

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ludtkemorgan ludtkemorgan added the 1 review needed Requires 1 more review before ready to merge label Sep 30, 2025
@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit ba704a6
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/68e3d219ad272600087006a1
😎 Deploy Preview https://deploy-preview-5400--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit ba704a6
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/68e3d21ab74e9b00088e47a1
😎 Deploy Preview https://deploy-preview-5400--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit ba704a6
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/68e3d21ab553000008db8bc4
😎 Deploy Preview https://deploy-preview-5400--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 1d35c11
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/68dbec6bf6fe1b0008ab1bda
😎 Deploy Preview https://deploy-preview-5400--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit ba704a6
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/68e3d21a2518cf0008f0173d
😎 Deploy Preview https://deploy-preview-5400--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing that Google deprios re-indexing pages it once saw have noindex and it could take up to 90 days for it to automatically re-scan and then start indexing again. Is that a concern?

@emilyjablonski emilyjablonski added questions and removed 1 review needed Requires 1 more review before ready to merge labels Sep 30, 2025
@emilyjablonski
Copy link
Collaborator

Also if there is an associated issue would love to link!

@ludtkemorgan ludtkemorgan added do not merge This PR is not ready to be merged. Do not merge even if it has the needed approvals and removed questions labels Sep 30, 2025
@ludtkemorgan
Copy link
Collaborator Author

@emilyjablonski ope, I didn't mean to add the "1 review needed" as this is not ready. I'm waiting to get confirmation from product on how to proceed as the ticket is still getting created. Sorry!

@ludtkemorgan ludtkemorgan changed the title fix: hide closed and draft listings from crawlers fix: hide closed listings from crawlers Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge This PR is not ready to be merged. Do not merge even if it has the needed approvals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants