Skip to content

[PM-28177] Add feature flag for Send UI refresh #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcamirault merged 1 commit into from
Dec 9, 2025
Merged

[PM-28177] Add feature flag for Send UI refresh #6708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Core/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ public static class FeatureFlagKeys
public const string UseSdkPasswordGenerators = "pm-19976-use-sdk-password-generators";
public const string UseChromiumImporter = "pm-23982-chromium-importer";
public const string ChromiumImporterWithABE = "pm-25855-chromium-importer-abe";
public const string SendUIRefresh = "pm-28175-send-ui-refresh";
Copy link
Contributor

@claude claude bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Clarification needed: Ticket number discrepancy

The PR title and description reference PM-28177, but the feature flag value uses pm-28175:

public const string SendUIRefresh = "pm-28175-send-ui-refresh";

Is this intentional? Common scenarios:

  • PM-28175 might be the epic/parent ticket for Send UI refresh
  • PM-28177 is the specific task for adding this server-side flag
  • The flag value should match PM-28175 for consistency with the epic

If PM-28175 is indeed the correct epic identifier, this is perfectly fine! Just want to confirm this wasn't a typo.

Note: Similar pattern exists with DesktopSendUIRefresh = "desktop-send-ui-refresh" on line 238, which suggests multiple flags for the same initiative across different scopes.


/* Vault Team */
public const string CipherKeyEncryption = "cipher-key-encryption";
Expand Down
Loading