Skip to content

Conversation

@mcamirault
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28177

📔 Objective

Add feature flag for the Send UI refresh epic

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@claude
Copy link
Contributor

claude bot commented Dec 8, 2025

Claude finished @mcamirault's task —— View job


Review Complete ✓

I've reviewed PR #6708 and the change looks good overall! Here's my assessment:

Overall: APPROVE

This is a clean, straightforward addition of a feature flag constant for the Send UI refresh initiative. The implementation follows Bitwarden's established patterns and conventions correctly.

Summary

✓ Code Quality: The constant declaration is syntactically correct and follows C# naming conventions
✓ Security: No security implications - simple string constant
✓ Naming: Follows PascalCase convention, consistent with other flags
✓ Placement: Correctly placed in Tools Team section

Question

I have one clarification question about the ticket numbering - I've posted it as an inline comment on line 242 in the file diff.

Detailed Findings

What's Good:

  • 👍 Proper placement in the /* Tools Team */ section (lines 237-242)
  • 👍 Naming convention matches existing feature flags perfectly
  • 👍 Value format "pm-28175-send-ui-refresh" follows established pattern
  • 👍 Maintains proper ordering within the team section
  • 👍 Related flag DesktopSendUIRefresh exists on line 238, showing good consistency for multi-platform Send UI refresh initiative

Observations:

  • ℹ️ No unit tests required - feature flag constants are simple string values
  • ℹ️ No breaking changes or migration concerns
  • ℹ️ Aligns with Bitwarden's feature flag pattern for gradual rollouts

public const string UseSdkPasswordGenerators = "pm-19976-use-sdk-password-generators";
public const string UseChromiumImporter = "pm-23982-chromium-importer";
public const string ChromiumImporterWithABE = "pm-25855-chromium-importer-abe";
public const string SendUIRefresh = "pm-28175-send-ui-refresh";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification needed: Ticket number discrepancy

The PR title and description reference PM-28177, but the feature flag value uses pm-28175:

public const string SendUIRefresh = "pm-28175-send-ui-refresh";

Is this intentional? Common scenarios:

  • PM-28175 might be the epic/parent ticket for Send UI refresh
  • PM-28177 is the specific task for adding this server-side flag
  • The flag value should match PM-28175 for consistency with the epic

If PM-28175 is indeed the correct epic identifier, this is perfectly fine! Just want to confirm this wasn't a typo.

Note: Similar pattern exists with DesktopSendUIRefresh = "desktop-send-ui-refresh" on line 238, which suggests multiple flags for the same initiative across different scopes.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Logo
Checkmarx One – Scan Summary & Details379e8236-bcd3-4e13-9774-f3f6de53f8b5

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.64%. Comparing base (01da3c9) to head (92697d1).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6708   +/-   ##
=======================================
  Coverage   53.64%   53.64%           
=======================================
  Files        1926     1926           
  Lines       85720    85720           
  Branches     7687     7687           
=======================================
  Hits        45981    45981           
  Misses      37967    37967           
  Partials     1772     1772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcamirault mcamirault requested a review from a team December 9, 2025 15:29
@mcamirault mcamirault merged commit dd74e96 into main Dec 9, 2025
51 checks passed
@mcamirault mcamirault deleted the tools/pm-28177/send-ui-refresh-flag branch December 9, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants