Skip to content

Conversation

LRNcardozoWDF
Copy link
Member

@LRNcardozoWDF LRNcardozoWDF commented Aug 22, 2025

🎟️ Tracking

PM-20288

📔 Objective

Adding a new workflow able to update the sdk to a given version and open a PR. This will be used by the sdk-internal repo when PRs are merged. The ability to test SDK PRs will be introduced in a future PR.

Based on bitwarden/android#5742, with the addition of the downgrade detection.

Test runs:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@LRNcardozoWDF LRNcardozoWDF requested review from a team and matt-livefront as code owners August 22, 2025 15:52
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.20%. Comparing base (5e3e952) to head (f237082).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
- Coverage   88.64%   85.20%   -3.44%     
==========================================
  Files         810     1004     +194     
  Lines       51124    61007    +9883     
==========================================
+ Hits        45319    51982    +6663     
- Misses       5805     9025    +3220     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Aug 22, 2025

Logo
Checkmarx One – Scan Summary & Details07fd9708-08f1-409c-a4a1-9e72d34adb04

Great job! No new security vulnerabilities introduced in this pull request

@LRNcardozoWDF LRNcardozoWDF force-pushed the cmcg/sdk-update-new-workflow branch from f96ca31 to ee73781 Compare August 22, 2025 17:43
@LRNcardozoWDF LRNcardozoWDF marked this pull request as draft August 23, 2025 08:00
@vvolkgang vvolkgang force-pushed the cmcg/sdk-update-new-workflow branch 4 times, most recently from 48c27c5 to 73306e3 Compare September 3, 2025 14:14
@vvolkgang vvolkgang changed the title New workflow to update the sdk [PM-20288] New workflow to update the sdk Sep 3, 2025
@vvolkgang vvolkgang force-pushed the cmcg/sdk-update-new-workflow branch from 73306e3 to 1a85e11 Compare September 3, 2025 16:02
@vvolkgang vvolkgang force-pushed the cmcg/sdk-update-new-workflow branch from 1a85e11 to f237082 Compare September 3, 2025 16:09
@vvolkgang vvolkgang marked this pull request as ready for review September 3, 2025 16:17
@vvolkgang vvolkgang enabled auto-merge (squash) September 3, 2025 16:18
@vvolkgang vvolkgang merged commit 6e8c618 into main Sep 3, 2025
13 of 14 checks passed
@vvolkgang vvolkgang deleted the cmcg/sdk-update-new-workflow branch September 3, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants