generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 77
[PM-20288] New workflow to update the sdk #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+289
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
- Coverage 88.64% 85.20% -3.44%
==========================================
Files 810 1004 +194
Lines 51124 61007 +9883
==========================================
+ Hits 45319 51982 +6663
- Misses 5805 9025 +3220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job! No new security vulnerabilities introduced in this pull request |
f96ca31
to
ee73781
Compare
fedemkr
reviewed
Aug 25, 2025
# Conflicts: # .github/workflows/sdlc-sdk-update.yml
48c27c5
to
73306e3
Compare
73306e3
to
1a85e11
Compare
1a85e11
to
f237082
Compare
fedemkr
reviewed
Sep 3, 2025
fedemkr
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-20288
📔 Objective
Adding a new workflow able to update the sdk to a given version and open a PR. This will be used by the sdk-internal repo when PRs are merged. The ability to test SDK PRs will be introduced in a future PR.
Based on bitwarden/android#5742, with the addition of the downgrade detection.
Test runs:
main
- https://github.com/bitwarden/ios/actions/runs/17435544778*. Downgrade detection - Update SDK to e6fa6b6 (1.0.0-unstable-1a2fc24) #1904
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes