Skip to content

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 3, 2025

🎟️ Tracking

PM-20288

📔 Objective

While reviewing older dependency update PRs I noticed we weren't updating Package.resolved in #1877. This file is used to cache SPM dependencies in Test workflows and needs to be kept up to date.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested review from a team and matt-livefront as code owners September 3, 2025 21:25
@vvolkgang vvolkgang enabled auto-merge (squash) September 3, 2025 21:25
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small question.

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.20%. Comparing base (6e8c618) to head (958ec81).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
- Coverage   88.64%   85.20%   -3.45%     
==========================================
  Files         810     1004     +194     
  Lines       51124    61007    +9883     
==========================================
+ Hits        45319    51981    +6662     
- Misses       5805     9026    +3221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Sep 3, 2025

Logo
Checkmarx One – Scan Summary & Details8a3dd4ac-a7b1-4ec9-8805-6abbbe87a59e

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang merged commit 86b4dc7 into main Sep 4, 2025
12 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/update-packageresolved branch September 4, 2025 12:32
@vvolkgang vvolkgang changed the title [PM-20288 ] On SDK update, also update Package.resolved [PM-20288] On SDK update, also update Package.resolved Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants