Open
Conversation
hiddemoll
force-pushed
the
hidde/add-programmable-mux
branch
from
e1448d9 to
0aa7c96
Compare
martijnbastiaan
approved these changes
Mar 20, 2026
Contributor
martijnbastiaan
left a comment
martijnbastiaan
left a comment
There was a problem hiding this comment.
Nice work!
I'll work on the endianness!
Comment on lines
+22
to
+25
| {- | A mux which switches its output from input 'A' to input 'B' when the local counter is | ||
| 'cycle_to_switch' and the device is armed. Once switched the mux cannot switched back | ||
| using the registers, but requires a reset. | ||
|
|
Contributor
There was a problem hiding this comment.
Hmm, this sentence isn't clear to me. Is "switching to" something that takes a cycle? I think I know the answer (no), but perhaps it is less ambiguous to call it first_b_cycle.
| , "A" ::: CSignal dom a | ||
| , "B" ::: CSignal dom a | ||
| ) | ||
| ( "B_RESET" ::: CSignal dom Bool |
Contributor
There was a problem hiding this comment.
Suggested change
| ( "B_RESET" ::: CSignal dom Bool | |
| ( "B_RESET" ::: Reset dom |
or
Suggested change
| ( "B_RESET" ::: CSignal dom Bool | |
| ( "B_ACTIVE" ::: Enable dom |
What do you think?
Contributor
Author
There was a problem hiding this comment.
Reset or Enable as a Protocol? That's unheard of. It does make more sense, but I discarded the idea before because I didn't think we'd have Protocol implementations of either of those.
Contributor
There was a problem hiding this comment.
| registerWbI | ||
| (registerConfig "arm") | ||
| { access = WriteOnly | ||
| , description = "Arm the mux to switch on cycle_to_switch. Prevents atomicity issues." |
Contributor
There was a problem hiding this comment.
Suggested change
| , description = "Arm the mux to switch on cycle_to_switch. Prevents atomicity issues." | |
| , description = "Arm the mux to switch on cycle_to_switch. Prevents atomicity issues when writing to cycle_to_switch." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
Add the programmable mux
Why (context, issues, etc.)
Part of #1109
Dear reviewer (anything you'd like the reviewer to pay close attention to?)
AI disclaimer (heads-up for more than inline autocomplete)
TODO
Cross-outany that do not applyUpdate documentation, including-> Will update the docs when I add the Wire Demodocs/