Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "View image" opens blank page #207

Open
f4ringo opened this issue Jan 28, 2020 · 20 comments
Open

Clicking "View image" opens blank page #207

f4ringo opened this issue Jan 28, 2020 · 20 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@f4ringo
Copy link

f4ringo commented Jan 28, 2020

I see blank page when I'm trying to open full size image

Steps

  1. Open any image in Google
  2. Click "View Image"
  3. See blank page

Pics
1.
image

  1. Opens this
    image

––––––––––––––––
Mac OS Catalina
Chrome 76.0.3809.132
ViewImage v3.2.2 (mac x86-64) - ru

@f4ringo f4ringo added the bug Something isn't working label Jan 28, 2020
@JustusGS
Copy link

JustusGS commented Jan 29, 2020

Same issue occurring for me. I assume Google changed something in the last few days.

MacOS Catalina 10.15.2
Chrome 79.0.3945.130
v3.2.2 (mac x86-64) - en_US

@SteveBaker
Copy link

Yeah - me too - on all platforms. Looks like Google did something.

@bijij
Copy link
Owner

bijij commented Feb 2, 2020

At the moment I can't repro unfortunately.
likely A:B testing on Google's end 😞

@bijij bijij added the help wanted Extra attention is needed label Feb 2, 2020
@ikeblaster
Copy link

@bijij I can confirm the issue. It looks like google is creating some temporary container with base64 image and then swaps it with new container which contains the image from real URL. But not always - if you switch image below preview (in right pane), then it just swaps img src attribute. Using mutation observer on the .n3VNCb (which are image previews) attributes seems to be reliable in both cases.

Please can you test this fixed version on your end? I wonder whether class tvh9oe was already present in OCT19 or we need to split it into JAN20. Sorry for not creating PR, too much hassle for one file when I don't know if works for everyone. :/

https://pastebin.com/h5GgVUnH

Tested in chrome and FF.

@bijij
Copy link
Owner

bijij commented Feb 2, 2020

This seems to work for me, I'm not sure if tvh9oe always existed or not.

I'll be happy to commit this and push a new version if you're okay with that.

@bijij
Copy link
Owner

bijij commented Feb 2, 2020

sorry @ikeblaster forgot to mention you.

@ikeblaster
Copy link

@bijij Of course, please do.

@bijij
Copy link
Owner

bijij commented Feb 3, 2020

Gone ahead and published a copy with those changes, lets see if it fixes it for people.

@Reonu
Copy link

Reonu commented Feb 4, 2020

@bijij I don't see any updates. Is it not published yet on the addon store?

@bijij
Copy link
Owner

bijij commented Feb 4, 2020

@Leon422 what version is your extension currently?

@Reonu
Copy link

Reonu commented Feb 4, 2020

@bijij v3.2.2 (win undefined) - undefined. I'm on Firefox. The addon store says the extension was last updated 3 months ago.

@bijij
Copy link
Owner

bijij commented Feb 4, 2020

@Leon422 I repushed to AMO should be live in a bit.

@Reonu
Copy link

Reonu commented Feb 4, 2020

@bijij It finally updated, and it's working fine again. Thanks!

@MrNotSoNice
Copy link

Thanks! It's working!

@f4ringo
Copy link
Author

f4ringo commented Feb 4, 2020

Thanks @bijij It’s working!

@needforsuv
Copy link

It still shows the thumbnail if you click view image for larger images where only the thumbnail loads

@needforsuv
Copy link

if the main image isn't one of the main ones

@tsuliwaensis
Copy link

I'm using v3.2.2 of the UserScript version on Chrome 81.0.4044.43, and this is still broken.

@JohannesMP
Copy link

This issue is still the case and seems to be occurring more frequently

@JohannesMP
Copy link

JohannesMP commented Jan 26, 2022

The 'Google Images Restored' extension appears to not suffer from this issue - https://chrome.google.com/webstore/detail/google-images-restored/ncndcebmkibkhopclfdjfacgfholcghi/related

Specifically for a given image result where with the 'View Image' extension exhibits this bug, viewing the same search and having the same search result with the 'Google Images Restored' extension installed will not cause this bug, and all images seem to both render their previews as well as as open the image as desired.

For the time being I would therefore recommend anyone that is encountering this issue with the 'View Image' extension to consider 'Google Images Restored' instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

10 participants