Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension doesn't work. #188

Closed
ghost opened this issue Oct 10, 2019 · 20 comments
Closed

Extension doesn't work. #188

ghost opened this issue Oct 10, 2019 · 20 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Oct 10, 2019

The extension does not work in Firefox.

Firefox Quantum

Screenshot:

screenshot-www google com-2019 10 10-14_54_35

Chrome

Screenshot:

www google com

@LOuroboros
Copy link

I'm getting the same result. The userscript version never worked for me, but the AddOn which did work correctly 2 months ago isn't working anymore either.

@bijij
Copy link
Owner

bijij commented Oct 26, 2019

I'll take a look into this tomorrow. Extension was still working fine for me up until today, Seems Google's pushing staggered changes.

@bijij bijij added the bug Something isn't working label Oct 26, 2019
@trlkly
Copy link

trlkly commented Oct 26, 2019

My problems were on Chrome, so I don't think this is Firefox specific. Changing the title might be appropriate so that people don't keep reporting the bug.

@bijij bijij changed the title It doesn't work in Firefox. Extension doesn't work. Oct 26, 2019
@bijij bijij pinned this issue Oct 26, 2019
@bijij bijij self-assigned this Oct 26, 2019
@bijij
Copy link
Owner

bijij commented Oct 26, 2019

commit dbcd909 is a quick and dirty fix.
it's been pushed to webstores as well.

seems google is now changing the URL the image redirects to last second so the extension only sees a lower resolution interim image.

I'm likely going to need help with finding the original source image now.

@bijij bijij added the help wanted Extra attention is needed label Oct 26, 2019
@needforsuv
Copy link

you can use the image url from the main search box

https://www.google.com/search?as_st=y&tbm=isch&hl=en&as_q=rotodyne&as_epq=&as_oq=&as_eq=&cr=&as_sitesearch=&safe=images&tbs=isz:lt,islt:10mp#imgrc=CrE0zdL-6oQHBM:

/imgres?imgurl=https%3A%2F%2Fhushkit.files.wordpress.com%2F2016%2F12%2F24555339.jpg&imgrefurl=https%3A%2F%2Fhushkit.net%2F2016%2F12%2F19%2Fthe-10-coolest-cancelled-airliners%2F&docid=ihDmEM_aGU67lM&tbnid=CrE0zdL-6oQHBM%3A&vet=10ahUKEwi38snI-7zlAhU38XMBHbAuBOIQMwguKAIwAg..i&w=4872&h=3388&hl=en&safe=images&bih=800&biw=1370&as_q=rotodyne&ved=0ahUKEwi38snI-7zlAhU38XMBHbAuBOIQMwguKAIwAg&iact=mrc&uact=8

@dynoChris
Copy link

Yes, doesn't work. Already more than a month.

@bijij
Copy link
Owner

bijij commented Oct 28, 2019

@needforsuv can you elaborate as to how you got that 2nd url from the searchbox doesn't appear for me.
possibly A/B testing on googles end related?

@softyoda
Copy link

@trlkly
Copy link

trlkly commented Oct 28, 2019 via email

@needforsuv
Copy link

@bijij

right click image tile, inspect element, parent class of thumbnail contains a href with the full url along with the referrer

works with both the one with jsname=sTFXNd ('new' one with different font) and the one with jsname=hSRGPd (the 'old' one that I have)

You can test A/B by opening a incognito window and installing something like EditThisCookie and deleting ALL the cookies and refreshing over and over until you hit the right one

@needforsuv
Copy link

needforsuv commented Oct 30, 2019

And I found the cookie differences:

If I paste the cookies and apply them, I can switch between both 'versions' without doing hit and miss (once I got one I exported the cookies) but 3.1.0 works with neither version that produce either these cookies

OLD:

[
{
    "domain": ".google.com",
    "expirationDate": 1575031340,
    "hostOnly": false,
    "httpOnly": false,
    "name": "1P_JAR",
    "path": "/",
    "sameSite": "no_restriction",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "2019-10-30-12",
    "id": 1
},
{
    "domain": ".google.com",
    "expirationDate": 1587991339.763164,
    "hostOnly": false,
    "httpOnly": true,
    "name": "CGIC",
    "path": "/search",
    "sameSite": "no_restriction",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "Ikp0ZXh0L2h0bWwsYXBwbGljYXRpb24veGh0bWwreG1sLGFwcGxpY2F0aW9uL3htbDtxPTAuOSxpbWFnZS93ZWJwLCovKjtxPTAuOA",
    "id": 2
},
{
    "domain": ".google.com",
    "expirationDate": 1588250541.061072,
    "hostOnly": false,
    "httpOnly": true,
    "name": "NID",
    "path": "/",
    "sameSite": "no_restriction",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "190=Gn6srGAL0ebrOBDgzj3ubz46_yD3K5F7mBm7QsSG9s3Ck4aN2SQuvGJDUSlvtR5Sy4IlL6a8bq_6vR5d6cDNqYadKnq0vdXuDwNLrVvWSQKDtMybHMlDaff-EG1RqjyWKkgf0X_vxWh3NsuC5oHNlEJiBrm0YrZL26CSGkAsqZA",
    "id": 3
},
{
    "domain": ".google.com",
    "expirationDate": 1575031340,
    "hostOnly": false,
    "httpOnly": false,
    "name": "OGPC",
    "path": "/",
    "sameSite": "no_restriction",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "19008563-1:",
    "id": 4
},
{
    "domain": "www.google.com",
    "expirationDate": 1572525740,
    "hostOnly": true,
    "httpOnly": false,
    "name": "UULE",
    "path": "/",
    "sameSite": "no_restriction",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "a+cm9sZToxIHByb2R1Y2VyOjEyIHByb3ZlbmFuY2U6NiB0aW1lc3RhbXA6MTU3MjQzOTMyOTM2MDAwMCBsYXRsbmd7bGF0aXR1ZGVfZTc6LTI3NDY5NzcwNyBsb25naXR1ZGVfZTc6MTUzMDI1MTIzNX0gcmFkaXVzOjYyOTM1MjA4MA==",
    "id": 5
}
]

NEW:

[
{
    "domain": ".google.com",
    "expirationDate": 1575031381,
    "hostOnly": false,
    "httpOnly": false,
    "name": "1P_JAR",
    "path": "/",
    "sameSite": "no_restriction",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "2019-10-30-12",
    "id": 1
},
{
    "domain": ".google.com",
    "expirationDate": 1588250580.438462,
    "hostOnly": false,
    "httpOnly": true,
    "name": "NID",
    "path": "/",
    "sameSite": "no_restriction",
    "secure": false,
    "session": false,
    "storeId": "1",
    "value": "190=YjEXFXOu00oamB0b6LGFh-OxnsthQb4IXCzkkhfIxQqhmo5luKXNoeFBtyo38vACbhOD0zQnT-oR53e3FTvo1J_CZgbly04bYVqM_1kLU78Rx1QDqs9QmYgVVHSKUqQJreurx0SzGecClw4uQGqlkieWWm97VkqvqEnBaZMlFqk",
    "id": 2
},
{
    "domain": "www.google.com",
    "expirationDate": 1575031382,
    "hostOnly": true,
    "httpOnly": false,
    "name": "OTZ",
    "path": "/",
    "sameSite": "no_restriction",
    "secure": true,
    "session": false,
    "storeId": "1",
    "value": "5168923_16_16__16_",
    "id": 3
}
]

(Incognito, so I am not too worried about sharing those)

@benounnas
Copy link

i'm using chromium Version 77.0.3865.90, same here doesn't work, is there any fix?

@bijij
Copy link
Owner

bijij commented Oct 31, 2019

@needforsuv parent doesn't seem to have full URL for me anymore.
Or at least not on chromium. I'll take another look tonight though might have just missed it.

@needforsuv
Copy link

@bijij

for reference, I'm talking about (the tile parent before you click in)
tile parent before you click in

on another note, while running 3.0.4 that does work for me

I found that some related images don't show buttons at all

Example:
https://www.google.com/search?as_st=y&tbm=isch&hl=en&as_q=rotodyne&as_epq=&as_oq=&as_eq=&cr=&as_sitesearch=&safe=images&tbs=isz:lt,islt:10mp#imgrc=wV-3UyHXtN_iBM:

(I also tried with this extension)
https://chrome.google.com/webstore/detail/view-image-download-image/kkdejhcahmppjoakalgdnnjpnmjlahhi?utm_source=chrome-app-launcher-info-dialog

The behaviours seems similar to yours in that it grabs the image from the preview box, and doesn't show buttons on the same related images

@bijij
Copy link
Owner

bijij commented Nov 1, 2019

@needforsuv no longer there for me.
Class names are also completely different for me now. All being 6 char mixed case strings.

No chance you could make a PR which fixes it for you while I figure out what to do for my case where that doesn't exist.

@bijij
Copy link
Owner

bijij commented Nov 1, 2019

Found a workaround for me.
Uses the raw source array which is deleted at run-time.
Clunky fix but seems like it'll do the trick.

Gonna release a version using it now.
Let me know if it works for you.

Works for me on chrome / ff.

This was referenced Nov 1, 2019
@LOuroboros
Copy link

Found a workaround for me.
Uses the raw source array which is deleted at run-time.
Clunky fix but seems like it'll do the trick.

Gonna release a version using it now.
Let me know if it works for you.

Works for me on chrome / ff.

Can confirm. The Firefox AddOn is working on my end too using Mozilla Firefox v70.0.1 (64 Bits).

@needforsuv
Copy link

@bijij 3.2.0 works for me (about the same as 3.0.4 where some related images don't work and larger images with only thumbnails only link to the thumbnail)

My workaround (adapted code from this chrome extension - it redirects to the webpage which is no good, so I made it point to the image and click open link in new tab, bypassing the pesky google image 'preview' layer)

function checkandoverride() {
  var loc=window.location.href
  
  if(getParameterByName("imgurl") != "" && loc.indexOf("google") > 0)
	document.location=getParameterByName("imgurl");
	
/*
	if(getParameterByName("rurl") != "" && loc.indexOf("yahoo") > 0 )
		document.location=decodeURIComponent(getParameterByName("rurl"));
		
	if(getParameterByName("desturi") != "" && loc.indexOf("ask") > 0 )
		document.location=decodeURIComponent(getParameterByName("desturi")); */
}

function getParameterByName(name)
{
  name = name.replace(/[\[]/, "\\\[").replace(/[\]]/, "\\\]");
  var regexS = "[\\?&]" + name + "=([^&#]*)";
  var regex = new RegExp(regexS);
  var results = regex.exec(window.location.search);
  if(results == null)
    return "";
  else
    return decodeURIComponent(results[1].replace(/\+/g, " "));
}

checkandoverride();

(I'm not sure how you'd even get the image url once you clicked in on those related images, it's only there before you click in)

@needforsuv
Copy link

@bijij

The raw source array method doesn't work completely ('OCT19' version), I can still click through enough related images where while the preview loads the 'full' image (as indexed by google possibly with any resizing), the view image button only shows the encrypted thumbnail (also happens with large images where google doesn't load the full image.

So a fix that fixes that should also fix it for the 'JUL19' version. (If you do get the image url before a click, that'll probably naturally only work forwards not backwards... - easy enough, you just go back another step before going forwards)

(I think the raw source array only works for images present on the main search page, not the right hand side panel/related images.)

Fun fact: the 'OCT19' version doesn't work with some advanced search operators like Xmp, so I don't think it's permanent (I did see it logged in back a while ago back in august?)

Why must google make this SO hard, the image url is already in the href, anybody can see and visit it with the right extension / script, why bother obfuscating it?

PS: A lot of github features/buttons don't work for me (like edit, etc.) where it did once upon a time with my browser - the UI looks the same, but now it just doesn't work properly for me (unsupported blah blah, github should be accessible from practically anything!). So I apologise for any 'double' posts or formatting mistakes, I can only do so much with markdown...

@bijij
Copy link
Owner

bijij commented Feb 3, 2020

Going to mark this as closed for now I think the issues here have either been fixed or superseded by #207

@bijij bijij closed this as completed Feb 3, 2020
@bijij bijij unpinned this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants