Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Image button sometimes not visible after reloading #236

Open
JohannesMP opened this issue Jan 26, 2022 · 0 comments
Open

View Image button sometimes not visible after reloading #236

JohannesMP opened this issue Jan 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@JohannesMP
Copy link

JohannesMP commented Jan 26, 2022

Describe the bug
Under certain conditions, reloading the google images search results window while an image search result is selected will cause the 'View Image' button to not appear after the page has reloaded.

To Reproduce
Video Screen Capture of Repro steps

  • Open https://www.google.com/imghp?hl=en in a new Chrome Incognito instsance
  • Search for shaq cat wiggle gif
  • Select the first image result (as of this recording that is the first giphy.com result)
    • Note that the 'View Image' button is visible as expected
  • Refresh the page (Ctrl+R, F5 or manually clicking the reload button)
    • Note the giphy.com result is still selected
    • Note that the 'View Image' button is still visible as expected
  • Select the image search result (as of this recording that is the first sbnation.com result)
    • Note that the 'View Image' button is visible as expected
  • Refresh the page again
    • Note the sbnation.com result is still selected
    • However the 'View Image' button is NOT visible as it should be
  • Clicking on a different result and back will result in the 'View Image' button being visible as expected.
  • Even with the third result selected, all following reloads appear to work as expected; The 'View Image' button only disappears on the first reload on that result and not for consecutive reloads.

Expected behavior
The 'View Image' button should always render as expected.

System Information

  • Chrome for Windows, 97.0.4692.99 (Official Build) (64-bit)
  • No other extensions enabled in Incognito mode
  • View Image extension for Chrome Version 3.6.0

Additional context
While it may not be related, there are some interesting other differences between the first and 3rd image results shown in the repro steps and screen capture above:

  • The first result (giphy.com, which does not break when reloading) plays back as expected, and clicking 'View Image' opens a new tab that is not just blank.
  • The third result (sbnation.com, which DOES break when reloading the first time) does not play back its footage, And clicking 'View Image' opens up a new tab that is just blank.

This seems like it may relate to #207

Just in case it may make a difference, with google having rolled out the 'Search images with google lens' feature that replaces the old right click option for reverse image searching images, I the have chrome://flags/#enable-lens-region-search disabled.

@JohannesMP JohannesMP added the bug Something isn't working label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant