feat: Add Flink-flavored REGEXP_EXTRACT in functions/flinksql#68
Open
ggjh-159 wants to merge 2 commits into
Open
feat: Add Flink-flavored REGEXP_EXTRACT in functions/flinksql#68ggjh-159 wants to merge 2 commits into
ggjh-159 wants to merge 2 commits into
Conversation
ggjh-159
changed the title
ggjh-159
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
related issue: bigo-sg/velox4j#51
Adds a new
velox/functions/flinksql/subtree (sibling tosparksql/andprestosql/) that owns Flink-flavored SQL function registrations, and registersREGEXP_EXTRACTunder Flink semantics.What's in this PR
velox/functions/flinksql/Register.{h,cpp}—registerFunctions(prefix)entrypoint.velox/functions/flinksql/RegexFunctions.{h,cpp}—makeRegexExtractcallsmakeRe2Extract(name, args, config, /*emptyNoMatch=*/false).velox/functions/flinksql/CMakeLists.txt+ wires upVELOX_ENABLE_FLINK_FUNCTIONSinvelox/CMakeLists.txtandvelox/functions/CMakeLists.txt.Testing
No UT added in this PR — behavior is exercised end-to-end through velox4j's
RegexpExtractTest.