feat(init): add FLINK preset with Flink-flavored function registration#54
Open
ggjh-159 wants to merge 1 commit into
Open
feat(init): add FLINK preset with Flink-flavored function registration#54ggjh-159 wants to merge 1 commit into
ggjh-159 wants to merge 1 commit into
Conversation
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: #51
Description
Adds a
FLINKpreset so Flink applications get Flink-flavored function registrations instead of inheriting Spark semantics.What's in this PR
Config.h—enum Preset { SPARK = 0, FLINK = 1 }.Config.cc— custompresetToStr/presetFromString(the defaultfolly::tryTo<Preset>rejects the enum and fails at runtime with"Value 'FLINK' cannot be converted to type velox4j::Preset").Init.cc:registerConnectors()out ofinitForSpark()— the 9 connector serde/registration blocks (fuzzer / hive / kafka / pulsar / filesystem / external-stream / nexmark / print / from-elements) now live in their own function.regexp_extractoverride insideinitForSpark()(reverting PR Fix REGEXP_EXTRACT to return NULL instead of empty string on no match #31's global override).initForFlink()that callsinitForSpark()+functions::flinksql::registerFunctions(). The reuse is intentional:velox/functions/flinksql/does not yet ship a full scalar/aggregate/window function set, so Flink still rides on sparksql as the baseline; the flinksql entry only overrides dialect-specific semantics(feat: Add Flink-flavored REGEXP_EXTRACT in functions/flinksql velox#68).Preset.java—KEY,SPARK,FLINKconstants forVelox4j.configure(...).Testing
mvn test -Dtest=RegexpExtractTest— 3/3 PASS under the FLINK preset (no-match returns NULL).