Free unused font atlases #21211
Open
Free unused font atlases #21211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed `TextFont` and `TextColor` from the `Text`, `Text2d`, and `TextSpan` requires, replaced with `ComputedTextStyle`. * `update_text_styles` updates the `ComputedTextStyle`s each frame from the text entities nearest ancestors with `TextFont` or `TextColor` components.
… for 2d and UI, resolve_2d_computed_text_styles and resolve_ui_computed_text_styles. * Added `scale_factor` field to `ComputedTextStyle`.
* Finished the `free_unused_font_atlases` system.
ickshonpe
added
A-Text
|
Is there an easier way to review a stacked PR? Having to mentally subtract out all the diffs from the previous change is a chore. |
I'm not sure, but all these other PRs are based on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #21210
Solution
Use a least recently used cache (suggested by @viridia). Don't free unused font atlases immediately, only once the font count is higher than the max fonts limit. Font atlases are never freed while their font is in use.
Performance Notes
For the sake of simplicity, plan to leave most of these for follow up PRs:
The LRU cache implementation isn't optimal, I just want to keep things simple for now as so many different text changes are needed.
The list of in use fonts is rebuilt every frame, this should be avoidable using some combination of change detection, observers, and reference counting. For most applications this won't be a problem though, as the numbers are relatively low.
Probably there should be a memory use limit and a hard limit to the total number of fonts.
Testing
Seems to work, except for TextSpans with Text2d.
Showcase