Skip to content

Conversation

neiesc
Copy link

@neiesc neiesc commented Sep 24, 2025

No description provided.

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bit nicer, as it's a thing people might feasibly want to look at these days. The x.1 tag is also nice to mention 🤔

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 24, 2025
@alice-i-cecile alice-i-cecile changed the title Update checkout command to v0.16.1 Update checkout command in examples README to v0.16.1 Sep 24, 2025
@alice-i-cecile alice-i-cecile changed the base branch from latest to main September 29, 2025 22:57
@alice-i-cecile alice-i-cecile changed the base branch from main to latest September 29, 2025 22:57
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be remade to target main.

@neiesc neiesc changed the base branch from latest to main September 29, 2025 23:13
@neiesc
Copy link
Author

neiesc commented Sep 29, 2025

This needs to be remade to target main.

done :)

Copy link
Contributor

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targeting the right branch now, but I think the robot is right: you need to modify the template that generates this as well.

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 30, 2025
@neiesc
Copy link
Author

neiesc commented Oct 10, 2025

Hi @alice-i-cecile and @janhohenheim , wait anything for me?

@mockersf
Copy link
Member

mockersf commented Oct 10, 2025

Checking out the dev version won't work, it doesn't exist in git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants