Skip to content

Expand CI tools #21145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Expand CI tools #21145

wants to merge 24 commits into from
+447 −0

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented Sep 21, 2025 •
edited
Loading

Objective

Sometimes a crate fails with a specific combination of features, it would be nice to have something to try and detect that.

Solution

Expand ci tool to run clippy with permutations of features for each crate

Testing

cargo run -p ci -- --build-jobs 4 clippys

Untested

  • clippy_android and bevy_android commands because i don't have Android SDK
  • clippy_dlss command because i don't have Dlss SDK

@hukasu hukasu mentioned this pull request Sep 21, 2025
Closed
@james7132 james7132 requested a review from mockersf September 21, 2025 01:20
@hukasu hukasu mentioned this pull request Sep 21, 2025
Closed
@hukasu
Copy link
Contributor Author

hukasu commented Sep 21, 2025

I will stop here and wait for a response from someone

@mockersf mockersf added A-Build-System Related to build systems or continuous integration X-Controversial There is active debate or serious implications around merging this PR labels Sep 21, 2025
@mockersf
Copy link
Member

this should be in the ci script and not require another tool

@hukasu hukasu changed the title Create a justfile template Expand CI tools Sep 21, 2025
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 21, 2025
@hukasu
Copy link
Contributor Author

hukasu commented Sep 23, 2025

@mockersf do i have a Go to continue on this?

@hukasu hukasu added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hukasu @mockersf @alice-i-cecile