Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually Configure webpack and electron-builder instead of using electron-webpack #5

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

benrbray
Copy link
Owner

@benrbray benrbray commented Mar 2, 2021

Resolves #4 . Noteworthy doesn't rely on any sophisticated features of electron-webpack, so it was straightforward (though laborious) to sift through the config files generated by electron-webpack and manually copy the bare-minimum important bits. More sophisticated functionality provided by electron-webpack such as hot-module-reloading is not included. The goal was to get up and running again as quickly as possible, so that I can upgrade to new major versions of Electron and TypeScript and resume working on features. If lack of HMR proves to be a frustration, I may add it back in later.

I was also able to delete some hacky config code required to glue on support for SolidJS to the electron-webpack config. The result is a much simpler configuration file that I can actually understand and change later! Working on this also gave me an opportunity to learn more about webpack and electron-builder, which I had more or less treated as black boxes until now.

…ration code; hot module reloading and develop mode remain to be added
@benrbray benrbray merged commit 3202d63 into master Mar 2, 2021
@benrbray benrbray deleted the chore/4/replace-electron-webpack branch March 2, 2021 17:20
@benrbray benrbray added the maintenance It ain't much, but it's honest work label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance It ain't much, but it's honest work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from electron-webpack, which is no longer maintained
1 participant