Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies (Electron 12.0, TypeScript 4.2.2, ProseMirror) #6

Merged
merged 11 commits into from
Mar 7, 2021

Conversation

benrbray
Copy link
Owner

@benrbray benrbray commented Mar 4, 2021

After a several-month-long development hiatus, several of the packages Noteworthy depends on received new major versions. After getting #5 is out of the way, I was able to start upgrading to the new versions.

Upgrading to TypeScript 4.2.2 only required the removal of a few delete operations. Upgrading to Electron 12.0.0 took more effort, as I decided to use this as an opportunity to finally set nodeIntegration: false and contextIsolation: true in the render process. This paves the way for user plugins that can safely query the web later.

Now that the render process has no access to Node APIs, it is necessary to use a Node-enabled preload script, which acts as a barrier between the Node APIs and the possibly-unsafe render process. This necessitated a new webpack entry point with the electron-preload target, and all the necessary webpack boilerplate to go along with it.

Helpful Resources:

@benrbray benrbray added the maintenance It ain't much, but it's honest work label Mar 4, 2021
@benrbray benrbray merged commit ab309d3 into master Mar 7, 2021
@benrbray benrbray deleted the chore/update-dependencies branch March 7, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance It ain't much, but it's honest work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant