[16.0][MIG] beesdoo_shift_swap -> shift_change#572
Open
Conversation
…ifts for irregular workers
Signed-off-by: Carmen Bianca Bakker <[email protected]>
remytms
force-pushed
the
16.0-mig-beesdoo_shift_swap
branch
4 times, most recently
from
3d07985 to
030dfe4
Compare
remytms
force-pushed
the
16.0-mig-beesdoo_shift_swap
branch
from
030dfe4 to
40f73c9
Compare
Collaborator
|
@remytms suggestion : can you reword "Change the same shift maximum" to "Maximum number of changes" and the description "Number of time the same shift can be changed" to "Maximum number of changes to any particular original shift" |
polchampion
reviewed
Feb 23, 2026
Fix bug where shifts cannot be ordered by shift.template. Factorize code for available shifts. Improve test readability.
polchampion
reviewed
Mar 10, 2026
remytms
force-pushed
the
16.0-mig-beesdoo_shift_swap
branch
5 times, most recently
from
679425b to
bcf2dcf
Compare
remytms
force-pushed
the
16.0-mig-beesdoo_shift_swap
branch
from
bcf2dcf to
26ed7c1
Compare
- remove useless group_by - prevent creating a new shift from the changes
In a controller, there is no transaction by default. So when calling create(), even if an error occurs, the object is written to the DB. Here, we need that Odoo rollback in case of an error during the creation of a shift change.
The controller overwrite the method available_shift_irregular_worker(). But this overwrite was not generic enough. It causes errors when the definition of the parent changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This brings
shift_changewhich brings some features of the thebeesdoo_shift_swapmodule.It keeps only the
swapmechanism. So regular worker can only unsubscribe from a shift and subscribe to a new empty one (only in the one already generated shifts).Odoo task (if applicable)
task
Checklist before approval