[ADD] shift_change_portal

Author: remytms

setup/shift_change_portal/odoo/addons/shift_change_portal

@@ -0,0 +1 @@
+../../../../shift_change_portal

setup/shift_change_portal/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)

shift_change/__init__.py

@@ -1 +1,5 @@
+# SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
 from . import models

shift_change/__manifest__.py

@@ -1,5 +1,6 @@
-# Copyright 2022 Coop IT Easy SC
-# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+# SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
 
 {
     "name": "Shift Change",

shift_change/data/system_parameter.xml

@@ -1,14 +1,16 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!--
+SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+
+SPDX-License-Identifier: AGPL-3.0-or-later
+-->
 <odoo noupdate="1">
-    <record id="enable_shift_changes" model="ir.config_parameter" forcecreate="False">
-        <field name="key">shift_change.enable_shift_changes</field>
-        <field name="value">True</field>
-    </record>
-    <record id="hour_limit_change" model="ir.config_parameter" forcecreate="False">
+    <record id="hour_limit_change" model="ir.config_parameter">
         <field name="key">shift_change.hour_limit_change</field>
         <field name="value">24</field>
     </record>
-    <record id="enable_solidarity" model="ir.config_parameter" forcecreate="False">
-        <field name="key">beesdoo_shift.enable_solidarity</field>
-        <field name="value">True</field>
+    <record id="same_shift_change_max" model="ir.config_parameter">
+        <field name="key">shift_change.same_shift_change_max</field>
+        <field name="value">3</field>
     </record>
 </odoo>

shift_change/models/__init__.py

@@ -1,2 +1,6 @@
+# SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
 from . import shift_change
 from . import res_config_settings

shift_change/models/res_config_settings.py

@@ -1,16 +1,18 @@
+# SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
 from odoo import fields, models
 
 
 class ResConfigSettings(models.TransientModel):
     _inherit = "res.config.settings"
 
-    # enable_exchanges
-    enable_shift_changes = fields.Boolean(
-        string="Activate shift changes",
-        config_parameter="shift_change.enable_shift_changes",
-    )
-    # day_limit_swap
     hour_limit_change = fields.Integer(
         string="Number of hours above which a cooperator cannot change his shift",
         config_parameter="shift_change.hour_limit_change",
     )
+    same_shift_change_max = fields.Integer(
+        string="Number of time the same shift can be changed",
+        config_parameter="shift_change.same_shift_change_max",
+    )

shift_change/models/shift_change.py

@@ -1,3 +1,7 @@
+# SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
 from datetime import datetime, timedelta
 
 from odoo import _, api, fields, models
@@ -32,50 +36,112 @@ def create(self, vals_list):
         to the old shift and subscribe him/her to the new one
         """
         res = super().create(vals_list)
-        res._unsubscribe_old_shift()
         res._subscribe_new_shift()
+        res._unsubscribe_old_shift()
         return res
 
     def _unsubscribe_old_shift(self):
         """
         Unsubscribe self.worker_id from old_shift
-        Return True is unsubscription is successful.
-        :return: Boolean
+        Raise error if not possible.
         """
-        if (
-            self.old_shift_id.worker_id
-            and self.old_shift_id.worker_id == self.worker_id
-        ):
-            self.old_shift_id.worker_id = False
-        else:
-            raise ValidationError(_("You can't change shift that your are not worker."))
+        self._check_old_shift(self.old_shift_id, self.worker_id)
+        self.old_shift_id.write(
+            {
+                "worker_id": False,
+                "is_regular": False,
+                "is_compensation": False,
+            }
+        )
 
     def _subscribe_new_shift(self):
         """
         Subscribe self.worker_id to the new shift
-        Return True is subscription is successful.
-        :return: Boolean
+        Raise error if not possible.
         """
+        self._check_new_shift(self.new_shift_id)
+        self.new_shift_id.write(
+            {
+                "worker_id": self.worker_id.id,
+                "is_regular": self.old_shift_id.is_regular,
+                "is_compensation": self.old_shift_id.is_compensation,
+            }
+        )
+
+    @api.model
+    def _check_old_shift(self, old_shift_id, worker_id):
+        """Check if old shift can be changed"""
+        try:
+            hour_limit_change = int(
+                self.env["ir.config_parameter"].get_param(
+                    "shift_change.hour_limit_change"
+                )
+            )
+        except ValueError:
+            # fall back to a default value
+            hour_limit_change = 0
+        if not old_shift_id.worker_id or old_shift_id.worker_id != worker_id:
+            raise ValidationError(_("You can't change shift that your are not worker."))
+        if old_shift_id.start_time <= datetime.now():
+            raise ValidationError(_("You can't change shift that is in the past."))
+        if old_shift_id.start_time <= datetime.now() + timedelta(
+            hours=hour_limit_change
+        ):
+            raise ValidationError(_("You can't change a shift so close in the futur."))
+        try:
+            same_shift_change_max = int(
+                self.env["ir.config_parameter"].get_param(
+                    "shift_change.same_shift_change_max"
+                )
+            )
+        except ValueError:
+            # fall back to a default value
+            same_shift_change_max = 0
+        if same_shift_change_max:
+            same_shift_change_nb = 0
+            tmp_old_shift_id = old_shift_id
+            while tmp_old_shift_id:
+                change = self.search(
+                    [
+                        ("new_shift_id", "=", tmp_old_shift_id.id),
+                        ("worker_id", "=", worker_id.id),
+                    ],
+                    limit=1,
+                )
+                if change:
+                    same_shift_change_nb += 1
+                    tmp_old_shift_id = change.old_shift_id
+                else:
+                    tmp_old_shift_id = None
+            if same_shift_change_nb >= same_shift_change_max:
+                raise ValidationError(
+                    _(
+                        "You can't change the same shift more than"
+                        f"{same_shift_change_max} times."
+                    )
+                )
+
+    @api.model
+    def _check_new_shift(self, new_shift_id):
+        """Check if shift can be changed or not"""
         try:
             hour_limit_change = int(
                 self.env["ir.config_parameter"].get_param(
                     "shift_change.hour_limit_change"
                 )
             )
         except ValueError:
-            # Fall back to a default value
+            # fall back to a default value
             hour_limit_change = 0
-        if self.new_shift_id.worker_id:
+        if new_shift_id.worker_id:
             raise ValidationError(
                 _("You can't subscribe to a shift assigned to someone else.")
             )
-        elif self.new_shift_id.start_time <= datetime.now():
+        if new_shift_id.start_time <= datetime.now():
             raise ValidationError(_("You can't subscribe to a shift in the past."))
-        elif self.new_shift_id.start_time <= datetime.now() + timedelta(
+        if new_shift_id.start_time <= datetime.now() + timedelta(
             hours=hour_limit_change
         ):
             raise ValidationError(
                 _("You can't subscribe to a shift so close in the futur.")
             )
-        else:
-            self.new_shift_id.worker_id = self.worker_id

shift_change/tests/__init__.py

@@ -1 +1,5 @@
+# SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
 from . import test_shift_change

shift_change/tests/test_shift_change.py

@@ -1,7 +1,14 @@
+# SPDX-FileCopyrightText: 2026 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
 from datetime import date, datetime, timedelta
 
+from psycopg2.errors import IntegrityError
+
 from odoo.exceptions import AccessError, ValidationError
 from odoo.tests.common import TransactionCase
+from odoo.tools import mute_logger
 
 
 class TestShiftChange(TransactionCase):
@@ -29,8 +36,8 @@ def setUp(self):
             {
                 "name": "shift_1",
                 "task_template_id": self.task_template_1.id,
-                "start_time": self.now,
-                "end_time": self.now,
+                "start_time": self.now + timedelta(days=2),
+                "end_time": self.now + timedelta(days=2),
                 "is_regular": True,
                 "worker_id": self.worker_regular_1.id,
             }
@@ -39,8 +46,8 @@ def setUp(self):
             {
                 "name": "shift_2",
                 "task_template_id": self.task_template_2.id,
-                "start_time": self.now,
-                "end_time": self.now,
+                "start_time": self.now + timedelta(days=2),
+                "end_time": self.now + timedelta(days=2),
                 "is_regular": True,
                 "worker_id": self.worker_regular_2.id,
             }
@@ -49,16 +56,16 @@ def setUp(self):
             {
                 "name": "shift_3",
                 "task_template_id": self.task_template_2.id,
-                "start_time": self.now + timedelta(days=2),
-                "end_time": self.now + timedelta(days=2),
+                "start_time": self.now + timedelta(days=4),
+                "end_time": self.now + timedelta(days=4),
                 "worker_id": False,
             }
         )
         self.shift_4 = self.shift_model.create(
             {
                 "name": "shift_4",
                 "task_template_id": self.task_template_2.id,
-                "start_time": self.now - timedelta(days=2),
+                "start_time": self.now - timedelta(days=4),
                 "end_time": self.now,
                 "worker_id": False,
             }
@@ -67,7 +74,7 @@ def setUp(self):
             {
                 "name": "shift_5",
                 "task_template_id": self.task_template_2.id,
-                "start_time": self.now + timedelta(days=2),
+                "start_time": self.now + timedelta(days=4),
                 "end_time": self.now,
                 "worker_id": False,
             }
@@ -85,6 +92,11 @@ def setUp(self):
         # Set context to avoid shift generation in the past
         self.env.context = dict(self.env.context, visualize_date=date.today())
 
+        # Set maximum change shift for testing
+        self.env["ir.config_parameter"].set_param(
+            "shift_change.same_shift_change_max", 1
+        )
+
     def test_shift_change(self):
         """Test change a shift"""
         self.assertEqual(self.shift_1.worker_id, self.worker_regular_1)
@@ -99,6 +111,29 @@ def test_shift_change(self):
         self.assertFalse(self.shift_1.worker_id)
         self.assertEqual(self.shift_3.worker_id, self.worker_regular_1)
 
+    def test_shift_change_max(self):
+        """Test change a shift several times"""
+        self.assertEqual(self.shift_1.worker_id, self.worker_regular_1)
+        self.assertFalse(self.shift_3.worker_id)
+        self.assertFalse(self.shift_5.worker_id)
+        self.shift_change_model.create(
+            {
+                "worker_id": self.worker_regular_1.id,
+                "old_shift_id": self.shift_1.id,
+                "new_shift_id": self.shift_3.id,
+            }
+        )
+        self.assertFalse(self.shift_1.worker_id)
+        self.assertEqual(self.shift_3.worker_id, self.worker_regular_1)
+        with self.assertRaises(ValidationError):
+            self.shift_change_model.create(
+                {
+                    "worker_id": self.worker_regular_1.id,
+                    "old_shift_id": self.shift_3.id,
+                    "new_shift_id": self.shift_5.id,
+                }
+            )
+
     def test_shift_change_not_empty(self):
         """Test changing a shift to a non empty shift"""
         self.assertEqual(self.shift_1.worker_id, self.worker_regular_1)
@@ -142,12 +177,13 @@ def test_shift_change_wrong_worker(self):
 
     def test_shift_change_missing_required_fields(self):
         """Test creating a shift with missing fields"""
-        with self.assertRaises(ValidationError):
-            self.shift_change_model.create(
-                {
-                    "worker_id": self.worker_regular_1.id,
-                }
-            )
+        with self.assertRaises(IntegrityError):
+            with mute_logger("odoo.sql_db"):
+                self.shift_change_model.create(
+                    {
+                        "worker_id": self.worker_regular_1.id,
+                    }
+                )
 
     def test_shift_change_writing(self):
         """Test that writing to a shift fails"""