Skip to content

fix: add missing windows arm64 in os_arch_names #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

fix: add missing windows arm64 in os_arch_names #3856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nodejs/private/os_name.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ load(":node_versions.bzl", "NODE_VERSIONS")

OS_ARCH_NAMES = [
("windows", "amd64"),
("windows", "arm64"),
("darwin", "amd64"),
("darwin", "arm64"),
("linux", "amd64"),
Expand Down Expand Up @@ -78,4 +79,4 @@ def assert_node_exists_for_host(rctx):
if not node_exists_for_os(node_version, os_name(rctx), node_repositories):
fail("No nodejs is available for {} at version {}".format(os_name(rctx), node_version) +
"\n Consider upgrading by setting node_version in a call to node_repositories in WORKSPACE." +
"\n Note that Node 16.x is the minimum published for Apple Silicon (M1 Macs)")
"\n Note that Node 16.x is the minimum published for Apple Silicon (M1 Macs), and 20.x is the minimum for Windows ARM64.")