fix: add missing windows arm64 in os_arch_names #3856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3846 we added support for Windows arm64, but I forgot to add it to
OS_ARCH_NAMES
, so it's not actually working yet. This commit adds it.Ref: 12d90ec
PR Checklist
It looks like the CI test suite isn't running on arm64 hosts at all (though e.g.
windows-11-arm
GitHub Actions runners are available nowadays), so I'm not sure whether the team wants to add that to the test matrix. Happy to add it.Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when trying to use the
windows_arm64
toolchain, this error is thrown:Issue Number: N/A
What is the new behavior?
Once this has been merged, people will be able to use the
windows_arm64
toolchain.Does this PR introduce a breaking change?
Other information