Clarify migration semantics and harden v9 additive-schema guardrails - #2
Draft
bansalayush247 with Copilot wants to merge 4 commits into
Draft
Clarify migration semantics and harden v9 additive-schema guardrails#2bansalayush247 with Copilot wants to merge 4 commits into
bansalayush247 with Copilot wants to merge 4 commits into
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: bansalayush247 <116891199+bansalayush247@users.noreply.github.com> Agent-Logs-Url: https://github.com/bansalayush247/fedimint-observer/sessions/7b630b56-bb78-4539-b6a4-7d0091421484
Copilot
AI
changed the title
[WIP] Check v9.sql for table modifications or new creations
Make schema v9 explicitly additive and fail-fast on drift
Mar 24, 2026
Co-authored-by: bansalayush247 <116891199+bansalayush247@users.noreply.github.com> Agent-Logs-Url: https://github.com/bansalayush247/fedimint-observer/sessions/bc082a67-d8ae-4d0f-bc30-17fdcc417538
Co-authored-by: bansalayush247 <116891199+bansalayush247@users.noreply.github.com> Agent-Logs-Url: https://github.com/bansalayush247/fedimint-observer/sessions/bc082a67-d8ae-4d0f-bc30-17fdcc417538
Copilot
AI
changed the title
Make schema v9 explicitly additive and fail-fast on drift
Clarify migration semantics and harden v9 additive-schema guardrails
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue asked what migrations actually do in this repository and whether v9 is modifying existing schema vs creating new schema. This PR makes migration behavior explicit in docs and tightens the v9 migration assertions to reflect additive-only intent.
Migration behavior documentation
schema_versionschema_setup,migration,migration_backfill) and current mapping (v0-v6setup-only,v7-v9upgrade-capable).v9 migration intent made explicit
v9is additive and limited to creating thegatewaystable + indexes (no alter/drop of existing tables).v9 test strengthened
v9_schema_is_additive_onlyto:📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.