Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.x]Update README.md and Ballerina.toml files #1550

Closed
wants to merge 1 commit into from
Closed

[1.8.x]Update README.md and Ballerina.toml files #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@ For more information on the supported operations, go to [Using the OpenAPI Tools

### Setting Up the Prerequisites

1. OpenJDK 11 ([Adopt OpenJDK](https://adoptopenjdk.net/) or any other OpenJDK distribution)
1. Download and install Java SE Development Kit (JDK) version 17 (from one of the following locations).

>**Info:** You can also use [Oracle JDK](https://www.oracle.com/java/technologies/javase-downloads.html). Set the JAVA_HOME environment variable to the pathname of the directory into which you installed JDK.
* [Oracle](https://www.oracle.com/java/technologies/downloads/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to suggest oracle distributions in our README files (as it can be misleading for our own internal users within WSO2)? @keizer619 WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Lets suggest Open JDK

* [OpenJDK](https://adoptium.net/)

> **Note:** Set the JAVA_HOME environment variable to the path name of the directory into which you installed JDK.

2. Export GitHub Personal access token with read package permissions as follows,
```
Expand Down
3 changes: 3 additions & 0 deletions module-ballerina-openapi/Ballerina.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ org= "ballerina"
name= "openapi"
version= "@toml.version@"

[platform.java17]
graalvmCompatible = true

[[platform.java17.dependency]]
path = "../openapi-validator/build/libs/[email protected]@.jar"
groupId = "ballerina"
Expand Down
Loading