[1.8.x]Update README.md and Ballerina.toml files #1550

lnash94 · 2023-10-02T04:56:24Z

Purpose

Update README.md file with Java 17 support
Update Ballerina.toml with graalVm support

NipunaRanasinghe · 2023-10-02T05:22:52Z

module-ballerina-openapi/Ballerina.toml

+[platform.java17]
+graalvmCompatible = true


How did we verify that the module is graalVM compatible? Have we configured a graalVM workflow to run module test using the native executable?

Since we only have ballerina code here, we can confirm its compatible right?

My mistake. We do have java dependencies in the module.

yeah we do use our core modules in here. so might need to come up with atleast a basic test suite to run on graalVM before marking as graalVM-compatible.

I'm curious about adding tests to verify GraalVM compatibility, especially since we have CLI and OpenAPI validator functionality that operates during compilation. I'll look into incorporating tests to ensure compatibility with GraalVM.
Appreciate it if anyone has any references or insights related to GraalVM compatibility testing, please feel free to share them :)

Looping in @TharmiganK

This is tool right? Since we are not executing the bal tools as GraalVM native images it is not required to be GraalVM compatible

@TharmiganK this is not the tool. We do have this ballerina/openapi library module to provide some annotation related to our openAPI validation support. So I think we should consider marking it as graalvm compatible (or not).

I see
Are these annotations only relevant when we call OAS generation?

If we do not have any runtime use cases we can mark it as GraalVM compatible to avoid the warnings when building (bal build/test --native or bal pack)

Btw why do we have a java dependency in the Ballerina.toml? I dont see any external calls to java

openapi-tools/module-ballerina-openapi/Ballerina.toml

Line 6 in 321ac86

[[platform.java17.dependency]]

Isn't this for the compiler plugin? I saw the same jar in the CompilerPlugin.toml :

openapi-tools/module-ballerina-openapi/CompilerPlugin.toml

Line 6 in 321ac86

path = "../openapi-validator/build/libs/[email protected]@.jar"

I think just removing it from the Ballerina.toml should work

NipunaRanasinghe · 2023-10-02T05:25:14Z

README.md


-    >**Info:** You can also use [Oracle JDK](https://www.oracle.com/java/technologies/javase-downloads.html). Set the JAVA_HOME environment variable to the pathname of the directory into which you installed JDK.
+    * [Oracle](https://www.oracle.com/java/technologies/downloads/)


Is it okay to suggest oracle distributions in our README files (as it can be misleading for our own internal users within WSO2)? @keizer619 WDYT?

Yes Lets suggest Open JDK

sonarqubecloud · 2023-10-02T06:11:25Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

codecov · 2023-10-02T06:54:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (e0cb2e9) to head (854eb27).
Report is 73 commits behind head on 1.8.x.

Additional details and impacted files

@@             Coverage Diff              @@
##              1.8.x    #1550      +/-   ##
============================================
+ Coverage     79.63%   81.43%   +1.80%     
- Complexity     1767     1964     +197     
============================================
  Files           124      124              
  Lines         10082    11184    +1102     
  Branches       1670     2110     +440     
============================================
+ Hits           8029     9108    +1079     
- Misses         1471     1479       +8     
- Partials        582      597      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-10-18T19:34:20Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2023-11-16T19:34:27Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2023-11-20T19:34:23Z

Closed PR due to inactivity for more than 18 days.

sonarqubecloud · 2023-12-04T10:01:09Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

github-actions · 2023-12-07T19:34:24Z

Closed PR due to inactivity for more than 18 days.

sonarqubecloud · 2024-01-17T09:34:47Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions · 2024-02-01T19:34:15Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-02-17T19:34:18Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-03-05T19:34:40Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-03-21T19:34:36Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-04-06T19:34:14Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-04-22T19:34:40Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-05-08T19:34:16Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-05-24T19:34:28Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

lnash94 · 2024-05-29T03:09:17Z

Close this PR since we checking the update of gralvm compatibility and resend the needful

lnash94 requested review from hevayo and NipunaRanasinghe as code owners October 2, 2023 04:56

lnash94 force-pushed the change-repo branch from f797b36 to 933668a Compare October 2, 2023 04:57

lnash94 requested review from dilanSachi and TharmiganK October 2, 2023 05:00

dilanSachi approved these changes Oct 2, 2023

View reviewed changes

NipunaRanasinghe reviewed Oct 2, 2023

View reviewed changes

Update README.md

854eb27

lnash94 force-pushed the change-repo branch from 933668a to 854eb27 Compare October 2, 2023 06:10

github-actions bot added the Stale label Oct 18, 2023

lnash94 removed the Stale label Oct 20, 2023

github-actions bot added the Stale label Nov 16, 2023

github-actions bot closed this Nov 20, 2023

lnash94 reopened this Dec 4, 2023

github-actions bot closed this Dec 7, 2023

lnash94 reopened this Jan 17, 2024

lnash94 removed the Stale label Jan 17, 2024

github-actions bot added the Stale label Feb 1, 2024

lnash94 removed the Stale label Feb 2, 2024

github-actions bot added the Stale label Feb 17, 2024

lnash94 removed the Stale label Feb 19, 2024

github-actions bot added the Stale label Mar 5, 2024

lnash94 removed the Stale label Mar 6, 2024

github-actions bot added the Stale label Mar 21, 2024

lnash94 removed the Stale label Mar 22, 2024

github-actions bot added the Stale label Apr 6, 2024

lnash94 removed the Stale label Apr 7, 2024

github-actions bot added the Stale label Apr 22, 2024

lnash94 removed the Stale label Apr 23, 2024

github-actions bot added the Stale label May 8, 2024

lnash94 removed the Stale label May 9, 2024

github-actions bot added the Stale label May 24, 2024

lnash94 removed the Stale label May 28, 2024

lnash94 closed this May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1.8.x]Update README.md and Ballerina.toml files #1550

[1.8.x]Update README.md and Ballerina.toml files #1550

lnash94 commented Oct 2, 2023

NipunaRanasinghe Oct 2, 2023

dilanSachi Oct 2, 2023

dilanSachi Oct 2, 2023

NipunaRanasinghe Oct 2, 2023

lnash94 Oct 2, 2023

NipunaRanasinghe Oct 2, 2023

TharmiganK Nov 1, 2023

NipunaRanasinghe Nov 1, 2023

TharmiganK Nov 1, 2023

TharmiganK Nov 1, 2023 •

edited

Loading

NipunaRanasinghe Oct 2, 2023

keizer619 Oct 3, 2023

sonarqubecloud bot commented Oct 2, 2023

codecov bot commented Oct 2, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 20, 2023

sonarqubecloud bot commented Dec 4, 2023

github-actions bot commented Dec 7, 2023

sonarqubecloud bot commented Jan 17, 2024

github-actions bot commented Feb 1, 2024

github-actions bot commented Feb 17, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Apr 6, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 24, 2024

lnash94 commented May 29, 2024


		>Info: You can also use [Oracle JDK](https://www.oracle.com/java/technologies/javase-downloads.html). Set the JAVA_HOME environment variable to the pathname of the directory into which you installed JDK.
		* [Oracle](https://www.oracle.com/java/technologies/downloads/)

		[platform.java17]
		graalvmCompatible = true

[1.8.x]Update README.md and Ballerina.toml files #1550

[1.8.x]Update README.md and Ballerina.toml files #1550

Conversation

lnash94 commented Oct 2, 2023

Purpose

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TharmiganK Nov 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 2, 2023

codecov bot commented Oct 2, 2023 • edited Loading

Codecov Report

github-actions bot commented Oct 18, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 20, 2023

sonarqubecloud bot commented Dec 4, 2023

github-actions bot commented Dec 7, 2023

sonarqubecloud bot commented Jan 17, 2024

Quality Gate passed

github-actions bot commented Feb 1, 2024

github-actions bot commented Feb 17, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Apr 6, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 24, 2024

lnash94 commented May 29, 2024

TharmiganK Nov 1, 2023 •

edited

Loading

codecov bot commented Oct 2, 2023 •

edited

Loading