Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make default HTTP client provider use the customer-provided config if present #1904

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

sichanyoo
Copy link
Contributor

Companion PR: smithy-lang/smithy-swift#914

Issue #

Description of changes

  • Pass the user-provided HTTP client config to HTTP client provider for the async and async throws service client config initializers which allow users to provide their own HTTP client config.

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… the async and async throws initializers of service client config, which allow users to provide their own HTTP client config.
@jbelkins jbelkins self-requested a review March 14, 2025 00:13
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending green build

@sichanyoo sichanyoo merged commit d7077cb into main Mar 14, 2025
25 checks passed
@sichanyoo sichanyoo deleted the fix/http-client-config-usage branch March 14, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants