fix: Make default HTTP client provider use the customer-provided config if present (#1904)

Co-authored-by: Sichan Yoo <[email protected]>
Co-authored-by: Josh Elkins <[email protected]>

Author: 3 people

Diff for: codegen/smithy-aws-swift-codegen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSHttpProtocolServiceClient.kt

@@ -95,7 +95,7 @@ class AWSHttpProtocolServiceClient(
                     ConfigProperty(
                         "httpClientEngine",
                         SmithyHTTPAPITypes.HttpClient,
-                        { it.format("AWSClientConfigDefaultsProvider.httpClientEngine()") },
+                        { it.format("AWSClientConfigDefaultsProvider.httpClientEngine(httpClientConfiguration)") },
                     )
                 }
                 "httpClientConfiguration" -> {
@@ -154,6 +154,9 @@ class AWSHttpProtocolServiceClient(
                         "responseChecksumValidation" -> {
                             writer.write("try AWSClientConfigDefaultsProvider.responseChecksumValidation(),")
                         }
+                        "httpClientEngine" -> {
+                            writer.write("AWSClientConfigDefaultsProvider.httpClientEngine(),")
+                        }
                         else -> {
                             writer.write("\$L,", property.default?.render(writer) ?: "nil")
                         }

Diff for: codegen/smithy-aws-swift-codegen/src/test/kotlin/software/amazon/smithy/aws/swift/codegen/awsrestjson/AWSRestJson1ProtocolGeneratorTests.kt

@@ -207,7 +207,7 @@ extension ExampleClient {
                 clientLogMode ?? AWSClientConfigDefaultsProvider.clientLogMode(),
                 endpoint,
                 idempotencyTokenGenerator ?? AWSClientConfigDefaultsProvider.idempotencyTokenGenerator(),
-                httpClientEngine ?? AWSClientConfigDefaultsProvider.httpClientEngine(),
+                httpClientEngine ?? AWSClientConfigDefaultsProvider.httpClientEngine(httpClientConfiguration),
                 httpClientConfiguration ?? AWSClientConfigDefaultsProvider.httpClientConfiguration(),
                 authSchemes ?? [AWSSDKHTTPAuth.SigV4AuthScheme()],
                 authSchemeResolver ?? DefaultExampleAuthSchemeResolver(),
@@ -261,7 +261,7 @@ extension ExampleClient {
                 clientLogMode ?? AWSClientConfigDefaultsProvider.clientLogMode(),
                 endpoint,
                 idempotencyTokenGenerator ?? AWSClientConfigDefaultsProvider.idempotencyTokenGenerator(),
-                httpClientEngine ?? AWSClientConfigDefaultsProvider.httpClientEngine(),
+                httpClientEngine ?? AWSClientConfigDefaultsProvider.httpClientEngine(httpClientConfiguration),
                 httpClientConfiguration ?? AWSClientConfigDefaultsProvider.httpClientConfiguration(),
                 authSchemes ?? [AWSSDKHTTPAuth.SigV4AuthScheme()],
                 authSchemeResolver ?? DefaultExampleAuthSchemeResolver(),