Skip to content

NPD namespace object #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NPD namespace object #8

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f515d52
addding npd namespace object
lipovsek-aws Mar 3, 2025
81e8393
opt-in namespace creation
lipovsek-aws Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions charts/neuron-helm-chart/templates/npd-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
{{- if .Values.npd.enabled }}
---
apiVersion: v1
kind: Namespace
metadata:
name: {{ include "neuron-node-problem-detector-and-recovery.namespace" . }}
Copy link
Contributor

@mounchin mounchin Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I have seen clusters already having neuron-healthcheck-system namespace when created, causing helm deployment failure due to ownership issues, so we have not added the namespace.

Copy link
Author

@lipovsek-aws lipovsek-aws Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case when exactly this namespace is created? In that case we can set npd to use different namespace?
Alternatively I think this requirement should be added to the readme.

Copy link
Contributor

@mounchin mounchin Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure when this ns is created tbh, yes we can update the readme to create the npd namespace if does not exist. Alternatively we can control this behavior using a flag to create a ns, by default its off.

labels:
app: {{ include "neuron-node-problem-detector-and-recovery.fullname" . }}
{{- include "neuron-node-problem-detector-and-recovery.labels" . | nindent 4 }}
---
apiVersion: apps/v1
kind: DaemonSet
metadata:
Expand Down