Skip to content

NPD namespace object #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NPD namespace object #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f515d52
addding npd namespace object
lipovsek-aws Mar 3, 2025
81e8393
opt-in namespace creation
lipovsek-aws Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/neuron-helm-chart/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ Expand the name of the chart.
Expand the namespace of the chart.
*/}}
{{- define "neuron-node-problem-detector-and-recovery.namespace" -}}
{{- default .Release.Namespace .Values.npd.namespaceOverride | trunc 63 | trimSuffix "-" -}}
{{- default .Release.Namespace .Values.npd.namespace.name | trunc 63 | trimSuffix "-" -}}
{{- end -}}

{{/*
Expand Down
1 change: 1 addition & 0 deletions charts/neuron-helm-chart/templates/npd-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{{- if .Values.npd.enabled }}
---
apiVersion: apps/v1
kind: DaemonSet
metadata:
Expand Down
9 changes: 9 additions & 0 deletions charts/neuron-helm-chart/templates/npd-namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{{- if and .Values.npd.enabled .Values.npd.namespace.create }}
apiVersion: v1
kind: Namespace
metadata:
name: {{ include "neuron-node-problem-detector-and-recovery.namespace" . }}
labels:
app: {{ include "neuron-node-problem-detector-and-recovery.fullname" . }}
{{- include "neuron-node-problem-detector-and-recovery.labels" . | nindent 4 }}
{{- end }}
4 changes: 3 additions & 1 deletion charts/neuron-helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ npd:
name: node-problem-detector-config
imagePullSecrets: []
nameOverride: node-problem-detector
namespaceOverride: neuron-healthcheck-system
namespace:
name: neuron-healthcheck-system
create: false
fullnameOverride: node-problem-detector
selectorLabelsOverride: {}
serviceAccount:
Expand Down