-
Notifications
You must be signed in to change notification settings - Fork 20
feat: grafana automatic dashboard and auth set #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AminR443
wants to merge
4
commits into
main
Choose a base branch
from
amin/grafana-provisioning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,46 @@ if ! grep -q '^http_port = 80$' /etc/grafana/grafana.ini; then | |
perl -pi -e 's/^;?http_port = .*/http_port = 80/' /etc/grafana/grafana.ini | ||
fi | ||
|
||
# configure username and password | ||
# TODO(amin): auto-generate some password for more security | ||
# TODO(amin): another possible option here is enabling google oauth, and this could give access | ||
# to anyone within our org emails | ||
sed -i -E "s|^;?\s*admin_user\s*=.*|admin_user = admin|" /etc/grafana/grafana.ini | ||
sed -i -E "s|^;?\s*admin_password\s*=.*|admin_password = firewoodisfast|" /etc/grafana/grafana.ini | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have wiki pages that say this password is "firewood_is_fast", so either change it here or find the wiki page. |
||
|
||
# provision data source and dashboards | ||
cat > /etc/grafana/provisioning/datasources/prometheus.yml <<EOF | ||
apiVersion: 1 | ||
datasources: | ||
- name: Prometheus | ||
type: prometheus | ||
access: proxy | ||
orgId: 1 | ||
url: http://localhost:9090 | ||
isDefault: true | ||
editable: true | ||
EOF | ||
|
||
cat > /etc/grafana/provisioning/dashboards/dashboards.yaml <<EOF | ||
apiVersion: 1 | ||
providers: | ||
- name: 'files' | ||
orgId: 1 | ||
folder: 'Provisioned' | ||
type: file | ||
disableDeletion: false | ||
editable: true | ||
options: | ||
path: /var/lib/grafana/dashboards | ||
foldersFromFilesStructure: true | ||
EOF | ||
|
||
# add firewood's dashboard and also node exporter full | ||
mkdir -p /var/lib/grafana/dashboards | ||
# TODO(amin): replace this with script dir | ||
wget -O /var/lib/grafana/dashboards/firewood.json https://github.com/ava-labs/firewood/raw/refs/heads/main/benchmark/Grafana-dashboard.json | ||
wget -O /var/lib/grafana/dashboards/node_exporter_full.json https://grafana.com/api/dashboards/1860/revisions/latest/download | ||
|
||
# configure prometheus to scrape firewood | ||
if ! grep -q '^ - job_name: firewood$' /etc/prometheus/prometheus.yml; then | ||
cat >> /etc/prometheus/prometheus.yml <<! | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is a little weird. I'm not sure if this happened because you missed a checkbox when you exported it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure this was checked when exporting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, this is intentional. I configured a datasource template that lets you choose the datasource, and also automatically selects the available prometheus one. If I didn't do that it didn't capture the datasource automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried a bit about how people will export updates to the dashboard. Can you add something to the readme that explains how that needs to happen now?