-
Notifications
You must be signed in to change notification settings - Fork 20
feat: grafana automatic dashboard and auth set #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
"datasource": { | ||
"type": "prometheus", | ||
"uid": "${DS_PROMETHEUS}" | ||
"uid": "${datasource}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is a little weird. I'm not sure if this happened because you missed a checkbox when you exported it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure this was checked when exporting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried a bit about how people will export updates to the dashboard. Can you add something to the readme that explains how that needs to happen now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please make the requested changes before merging.
# TODO(amin): another possible option here is enabling google oauth, and this could give access | ||
# to anyone within our org emails | ||
sed -i -E "s|^;?\s*admin_user\s*=.*|admin_user = admin|" /etc/grafana/grafana.ini | ||
sed -i -E "s|^;?\s*admin_password\s*=.*|admin_password = firewoodisfast|" /etc/grafana/grafana.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have wiki pages that say this password is "firewood_is_fast", so either change it here or find the wiki page.
This PR modifies the Grafana installation script to automatically provision the datasource and a dashboard directory. It also modifies the dashboard file with a configurable datasource so it automatically picks up the available prometheus one.