[tmpnet] Set an explicit instance label for logs and metrics
#3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
tmpnet-remove-save-port
branch
3 times, most recently
from
3fcd680 to
0ed567b
Compare
StephenButtolph
approved these changes
Jan 16, 2025
Previously, the configuuration for promtail and prometheus did not set an explicit `instance` label. This resulted in the default of `ip:port` being used, and since that could change on restart, it was necessary to try to ensure a stable port. Setting an explicit and unique value for `instance` avoids needing to ensure a stable port.
marun
force-pushed
the
tmpnet-remove-save-port
branch
from
0ed567b to
b588b87
Compare
1 task
michaelkaplan13
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously, the configuration for promtail and prometheus did not set an explicit
instancelabel. This resulted in the default ofip:portbeing used, and since that could change on restart, it was necessary to try to ensure a stable port. Setting an explicit and unique value forinstanceavoids needing to ensure a stable port.How this was tested
CI
Need to be documented in RELEASES.md?
N/a