[tmpnet] Update URI and StakingAddress usage in support of kube #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Jan 27, 2025
| func GetLocalURI(tc tests.TestContext, node *tmpnet.Node) string { | ||
| uri, cancel, err := node.GetLocalURI(tc.DefaultContext()) | ||
| require.NoError(tc, err) | ||
| tc.DeferCleanup(cancel) |
There was a problem hiding this comment.
why not just invoke defer cancel() ?
There was a problem hiding this comment.
defer would call it on function exit and then the caller wouldn't be able to use the URI. DeferCleanup ensures it gets called when the test has completed and the caller doesn't need the URI anymore.
yacovm
approved these changes
Jan 27, 2025
maru-ava
force-pushed
the
local-addresses
branch
from
3a627fc to
9adec71
Compare
Previously, Node.URI and Node.StakingAddress fields contained values for a local process and were always locally accessible. Nodes running in kubernetes may be running remotely, though, and only be accessible if e.g. a local port is forwarded to the port of a node's pod. To ensure compatibility with forwarded URIs and StakingAddresses, callers that aren't guaranteed to be running locally to a node are updated to access these values via functions that can ensure a remote endpoint is forwarded if the target node isn't running locally.
maru-ava
force-pushed
the
local-addresses
branch
from
9adec71 to
665c75f
Compare
|
Rebased |
qdm12
approved these changes
Feb 3, 2025
aaronbuchwald
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously,
Node.URIandNode.StakingAddressfields contained values for a local process and were always locally accessible. Nodes running in kubernetes may be running remotely, though, and only be accessible if e.g. a local port is forwarded to the port of a node's pod. To ensure compatibility with forwarded URIs and StakingAddresses, callers that aren't guaranteed to be running locally to a node are updated to access these values via functions that can ensure a remote endpoint is forwarded if the target node isn't running locally.How this was tested
CI
Need to be documented in RELEASES.md?
N/A
TODO
instancelabel for logs and metrics #3650