BUG: Fix feature transformation #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANGAreNotGnu
approved these changes
Nov 1, 2024
src/autogluon_assistant/transformer/feature_transformers/base.py
Outdated
Show resolved
Hide resolved
boranhan
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
When the datasets (specifically DS-Agent 17 datasets) contain label column in test data, the column was not being dropped before transformation. Also the test_id_column was being used for train set. That has been fixed.
NOTE: This PR needs careful review, please only approve after that (I'll merge it after a few more tests). Currently it was tested with toy_data inside the repo.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.