Update tracing logic in authn code #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
approved these changes
Feb 3, 2025
tstirrat15
force-pushed
the
fix-tracing-logic-in-postgres-rds-authn
branch
from
e8da317 to
5483495
Compare
tstirrat15
force-pushed
the
fix-tracing-logic-in-postgres-rds-authn
branch
from
5483495 to
ee76d5a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was pointed out to me, and the log is in the wrong place, and the error handling isn't idiomatic. This fixes both of these issues.
Changes
Reorganize logging logic
Testing
Review