Merge pull request #2230 from authzed/fix-tracing-logic-in-postgres-r…

…ds-authn Update tracing logic in authn code
authzed · Feb 3, 2025 · 98e88a1 · 98e88a1
2 parents abdc17d + ee76d5a
commit 98e88a1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/datastore/credentials.go b/pkg/datastore/credentials.go
@@ -87,7 +87,8 @@ func (d awsIamCredentialsProvider) IsCleartextToken() bool {
 func (d awsIamCredentialsProvider) Get(ctx context.Context, dbEndpoint string, dbUser string) (string, string, error) {
 	authToken, err := rdsauth.BuildAuthToken(ctx, dbEndpoint, d.awsSdkConfig.Region, dbUser, d.awsSdkConfig.Credentials)
 	if err != nil {
-		log.Ctx(ctx).Trace().Str("region", d.awsSdkConfig.Region).Str("endpoint", dbEndpoint).Str("user", dbUser).Msg("successfully retrieved IAM auth token for DB")
+		return "", "", err
 	}
-	return dbUser, authToken, err
+	log.Ctx(ctx).Trace().Str("region", d.awsSdkConfig.Region).Str("endpoint", dbEndpoint).Str("user", dbUser).Msg("successfully retrieved IAM auth token for DB")
+	return dbUser, authToken, nil
 }