Start consolodating Github REST API URLs into a central place#3685
Start consolodating Github REST API URLs into a central place#3685
Conversation
shlokgilda
left a comment
There was a problem hiding this comment.
Like the idea.
One thing that needs fixing before merge: there's an operator precedence bug in issues_endpoint_url that'll break the trailing_slash=False path. Python evaluates the ternary after the +, so when trailing_slash=False you get an empty string back instead of the URL without a slash. The issues endpoint actually hits this path, so it'd break issue collection.
Also, _base_url() is defined but never called. issues_endpoint_url still hardcodes the domain. Worth wiring that in since that's the whole point of the refactor.
Details in the inline comments.
|
Needs to be tested before merge. |
| github_data_access = GithubDataAccess(key_auth, logger) | ||
|
|
||
| # Set the base of the url and place to hold contributors to insert | ||
| contributors_url = github_data_access.contributors_endpoint_url(owner, repo) + "?state=all" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'repo' (undefined-variable)
There was a problem hiding this comment.
this commit shouldnt be here....
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
8a84148 to
e831bc5
Compare
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
Signed-off-by: Adrian Edwards <[email protected]>
e831bc5 to
5b6e5f8
Compare
|
currently testing on my dev instance |
Description
This takes inspiration from the discussion in #3597 and is a step towards resolving #3277
This pr:
Notes for Reviewers
Augur collection appears to run smoothly with this PR on my local dev instance, indicating this change doesnt cause breakage.
Signed commits