access GraphQL urls from the designated graphql helper class#3686
access GraphQL urls from the designated graphql helper class#3686
Conversation
Signed-off-by: Adrian Edwards <[email protected]>
shlokgilda
left a comment
There was a problem hiding this comment.
I like the @staticmethod approach. you don't need an instance just to get the URL.
It's actually better than what #3685 does on the REST side (where _base_url() is an instance method that's never used). Might be worth aligning the REST PR to follow this same pattern? Thoughts?
|
So i did graphQL in a different way because graphQL queries dont really rely on url paths or parameters, they send the information for the request in the body. I worry that by exposing the baseURL for REST in a similar way, consumers of this class may be encouraged to build their own queries (although i guess if theyre using the correct baseurl its probably fine???? |
|
Yeah makes sense, keeping them different is the right call. LGTM. |
This is not a comment with any valence. The REST API's rate limits are published and clear. The GraphQL API limits are generally greater, however we have observed they are also severely throttled from time to time. So, this is a "the more you know" sort of comment. This is the kind of thing we learn when collecting mass amounts of data for a while. |
sgoggins
left a comment
There was a problem hiding this comment.
Much more robust approach.
Description
This is essentially the same as #3685, but for the github graphQL API (another small step towards resolving #3277)
Notes for Reviewers
No testing done yet, pretty trivial change to set the pattern for how i want things to work with building URLs in the future
Signed commits