Moved unproven feature gates to trait impl blocks #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sympatron
commented
Jun 24, 2021
| @@ -30,24 +30,60 @@ impl Watchdog { | |||
| } | |||
| } | |||
|
|
|||
| fn feed(&mut wdt: WDT) { | |||
There was a problem hiding this comment.
This could be the way to go, until e-h traits aren't "unproven" anymore. But I am open for suggestions/better options.
|
Honestly, I'm starting to think we should enable |
|
That would be another solution. |
|
@sajattack, what do you think about making |
Yeah go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #426, this PR moves the feature gates to the impl blocks. That way, you can still use parts of these modules without
unproven.If this is something we want, I would probably add replacement methods in case
unprovenisn't active to make them useful again. And make the e-h trait impls wrappers around those.At this state some modules' main functions wouldn't be accessible.