Skip to content

fix: Improve error handling in types conversion #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Improve error handling in types conversion #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions atrium-api/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ use thiserror::Error;
pub enum Error {
#[error(transparent)]
IpldCoreSerde(#[from] ipld_core::serde::SerdeError),
#[error(transparent)]
SerdeJson(#[from] serde_json::Error),
#[error("not allowed in ATProtocol")]
NotAllowed,
}
Expand Down
2 changes: 1 addition & 1 deletion atrium-api/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ where
//
// For the time being, until this problem is resolved, use the workaround of serializing once to a json string and then deserializing it.
let json = serde_json::to_vec(&value).unwrap();
Ok(serde_json::from_slice(&json).unwrap())
Ok(serde_json::from_slice(&json)?)
}
}

Expand Down
Loading