fix: Improve error handling in types conversion #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SerdeJson error variant to Error enum - Replace unwrap() with proper error propagation in try_from_unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
ref #319
Details
This change improves error diagnostics by replacing unwrap() with proper error propagation in the
try_from_unknownfunction. While this doesn't directly fix the malformed date parsing issue reported in #319, it makes debugging easier by surfacing the actual errors instead of panicking.The specific improvements:
SerdeJson(#[from] serde_json::Error)variant to the Error enumserde_json::from_slice(&json).unwrap()withserde_json::from_slice(&json)?in types.rs:279This will help identify and debug issues like malformed dates from the BlueSky API by providing proper error messages instead of panic.