Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oct612x: Use ccflags-y instead of EXTRA_CFLAGS. #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions drivers/dahdi/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@ CFLAGS_MODULE += -I$(DAHDI_INCLUDE) -I$(src) -Wno-format-truncation
BAD_KERNELS_VERS := 22 34 34.0.1 34.0.2
BAD_KERNELS := $(foreach ver,$(BAD_KERNELS_VERS),2.6.9-$(ver).EL 2.6.9-$(ver).ELsmp)
ifneq (,$(filter $(KVERS),$(BAD_KERNELS)))
EXTRA_CFLAGS+=-Drw_lock_t=rwlock_t
ccflags-y+=-Drw_lock_t=rwlock_t
endif

# A number of Fedora 10 (9 also?) kernels backported hrtimer to 2.6.27
# as part of an ALSA backport. TODO: Any better way to detect that?
ifeq (1,$(shell fgrep -q ' hrtimer_set_expires' include/linux/hrtimer.h 2>/dev/null && echo 1))
EXTRA_CFLAGS+=-DHAVE_HRTIMER_ACCESSORS=1
ccflags-y+=-DHAVE_HRTIMER_ACCESSORS=1
endif

ifeq (1,$(shell fgrep -q 'wait_for_completion_timeout' include/linux/completion.h 2>/dev/null && echo 1))
Expand Down
5 changes: 1 addition & 4 deletions drivers/dahdi/oct612x/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ octapi_files = octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.o \
apilib/llman/octapi_llman.o \
oct612x-user.o

# TODO: ccflags was added in 2.6.24 in commit f77bf01425b11947eeb3b5b54. This
# should be changed to a conditional compilation based on the Kernel Version.
# ccflags-y := -I$(src)/.. -Wno-undef -I$(src)/include -I$(src)/octdeviceapi -I$(src)/octdeviceapi/oct6100api
EXTRA_CFLAGS = -I$(src)/.. -Wno-undef -I$(src)/include -I$(src)/octdeviceapi -I$(src)/octdeviceapi/oct6100api
ccflags-y := -I$(src)/.. -Wno-undef -I$(src)/include -I$(src)/octdeviceapi -I$(src)/octdeviceapi/oct6100api
obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_OCT612X) := oct612x.o
oct612x-objs := $(octapi_files)
5 changes: 1 addition & 4 deletions drivers/dahdi/oct612x/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,5 @@ octapi_files = octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.o \
apilib/largmath/octapi_largmath.o \
apilib/llman/octapi_llman.o

# TODO: ccflags was added in 2.6.24 in commit f77bf01425b11947eeb3b5b54. This
# should be changed to a conditional compilation based on the Kernel Version.
# ccflags-y := -I$(src)/.. -Wno-undef -I$(src)/include -I$(src)/octdeviceapi -I$(src)/octdeviceapi/oct6100api
EXTRA_CFLAGS = -I$(src)/.. -Wno-undef -I$(src)/include -I$(src)/octdeviceapi -I$(src)/octdeviceapi/oct6100api
ccflags-y := -I$(src)/.. -Wno-undef -I$(src)/include -I$(src)/octdeviceapi -I$(src)/octdeviceapi/oct6100api
lib-y := $(octapi_files)
6 changes: 3 additions & 3 deletions drivers/dahdi/opvxa1200/Kbuild
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_OPVXA1200) += opvxa1200.o

EXTRA_CFLAGS += -I$(src)/.. -Wno-undef
ccflags-y += -I$(src)/.. -Wno-undef

opvxa1200-objs := base.o

Expand All @@ -10,10 +10,10 @@ ifneq ($(DAHDI_KERNEL_H_PATH),)
DAHDI_SPAN_MODULE:=$(shell if grep -C 5 "struct dahdi_span {" $(DAHDI_KERNEL_H_PATH) | grep -q "struct module \*owner"; then echo "yes"; else echo "no"; fi)
DAHDI_SPAN_OPS:=$(shell if grep -q "struct dahdi_span_ops {" $(DAHDI_KERNEL_H_PATH); then echo "yes"; else echo "no"; fi)
ifeq ($(DAHDI_SPAN_MODULE),yes)
EXTRA_CFLAGS+=-DDAHDI_SPAN_MODULE
ccflags-y+=-DDAHDI_SPAN_MODULE
else
ifeq ($(DAHDI_SPAN_OPS),yes)
EXTRA_CFLAGS+=-DDAHDI_SPAN_OPS
ccflags-y+=-DDAHDI_SPAN_OPS
endif
endif
endif
4 changes: 2 additions & 2 deletions drivers/dahdi/voicebus/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ ifneq ($(HOTPLUG_FIRMWARE),yes)
dahdi_voicebus-objs += $(FIRM_DIR)/dahdi-fw-vpmoct032.o
$(warning WARNING: You are compiling firmware into voicebus.ko which is not available under the terms of the GPL. It may be a violation of the GPL to distribute the resulting image since it combines both GPL and non-GPL work. You should consult a lawyer of your own before distributing such an image.)
else
EXTRA_CFLAGS+=-DHOTPLUG_FIRMWARE
ccflags-y+=-DHOTPLUG_FIRMWARE
endif

EXTRA_CFLAGS += -I$(src)/.. -Wno-undef
ccflags-y += -I$(src)/.. -Wno-undef

$(obj)/$(FIRM_DIR)/dahdi-fw-vpmoct032.o: $(obj)/voicebus.o
$(MAKE) -C $(obj)/$(FIRM_DIR) dahdi-fw-vpmoct032.o
Expand Down
2 changes: 1 addition & 1 deletion drivers/dahdi/wcb4xxp/Kbuild
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
obj-m += wcb4xxp.o

EXTRA_CFLAGS += -I$(src)/.. -Wno-undef
ccflags-y += -I$(src)/.. -Wno-undef

wcb4xxp-objs := base.o

Expand Down
6 changes: 3 additions & 3 deletions drivers/dahdi/wct4xxp/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@ obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_WCT4XXP) += wct4xxp.o

FIRM_DIR := ../firmware

EXTRA_CFLAGS += -I$(src)/.. -I$(src)/../oct612x/ $(shell $(src)/../oct612x/octasic-helper cflags $(src)/../oct612x) -Wno-undef
ccflags-y += -I$(src)/.. -I$(src)/../oct612x/ $(shell $(src)/../oct612x/octasic-helper cflags $(src)/../oct612x) -Wno-undef

# The OCT612X source files are from a vendor drop and we do not want to edit
# them to make this warning go away. Therefore, turn off the
# unused-but-set-variable warning for this driver.

EXTRA_CFLAGS += $(call cc-option, -Wno-unused-but-set-variable)
ccflags-y += $(call cc-option, -Wno-unused-but-set-variable)

ifeq ($(HOTPLUG_FIRMWARE),yes)
EXTRA_CFLAGS+=-DHOTPLUG_FIRMWARE
ccflags-y+=-DHOTPLUG_FIRMWARE
endif

wct4xxp-objs := base.o vpm450m.o
Expand Down
4 changes: 2 additions & 2 deletions drivers/dahdi/wctc4xxp/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_WCTC4XXP) += wctc4xxp.o

FIRM_DIR := ../firmware

EXTRA_CFLAGS += -I$(src)/.. -Wno-undef
ccflags-y += -I$(src)/.. -Wno-undef

ifeq ($(HOTPLUG_FIRMWARE),yes)
EXTRA_CFLAGS+=-DHOTPLUG_FIRMWARE
ccflags-y+=-DHOTPLUG_FIRMWARE
endif

wctc4xxp-objs := base.o
Expand Down
2 changes: 1 addition & 1 deletion drivers/dahdi/wctdm24xxp/Kbuild
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_WCTDM24XXP) += wctdm24xxp.o

EXTRA_CFLAGS += -I$(src)/.. -Wno-undef
ccflags-y += -I$(src)/.. -Wno-undef

wctdm24xxp-objs := base.o xhfc.o
2 changes: 1 addition & 1 deletion drivers/dahdi/wcte12xp/Kbuild
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_WCTE12XP) += wcte12xp.o

EXTRA_CFLAGS += -I$(src)/.. -Wno-undef
ccflags-y += -I$(src)/.. -Wno-undef

wcte12xp-objs := base.o
4 changes: 2 additions & 2 deletions drivers/dahdi/xpp/Kbuild
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
EXTRA_CFLAGS = $(XPP_LOCAL_CFLAGS) \
ccflags-y = $(XPP_LOCAL_CFLAGS) \
-DDEBUG \
-DPOLL_DIGITAL_INPUTS \
-DDEBUG_PCMTX \
Expand Down Expand Up @@ -32,7 +32,7 @@ xpd_echo-objs += card_echo.o
xpp_mmap-objs += mmapbus.o mmapdrv.o

ifeq (y,$(PARPORT_DEBUG))
EXTRA_CFLAGS += -DDEBUG_SYNC_PARPORT
ccflags-y += -DDEBUG_SYNC_PARPORT
obj-m += parport_debug.o
endif

Expand Down