oct612x: Use ccflags-y instead of EXTRA_CFLAGS. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccflags-y was added to the kernel back in 2007, in commit f77bf01425b11947eeb3b5b54. Recent kernel commit dbd83ea09699390892e5efecddd74ae43a00f071 has now completely removed the deprecated EXTRA_CFLAGS. Comments in Kbuild and the Makefile for the oct612x library were added back when it was created in 2013 in commit f65299e to use the newer ccflags-y based on the kernel version, but the change was never made to conditionally move away from the EXTRA_CFLAGS. Now that the older way no longer exists, always use ccflags-y. Resolves: asterisk#76
InterLinked1
force-pushed
the
issue-76
branch
from
cc2a0dc to
ec88adb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccflags-y was added to the kernel back in 2007, in commit f77bf01425b11947eeb3b5b54. Recent kernel commit
dbd83ea09699390892e5efecddd74ae43a00f071 has now completely removed the deprecated EXTRA_CFLAGS.
Comments in Kbuild and the Makefile for the oct612x library were added back when it was created in 2013 in commit f65299e to use the newer ccflags-y based on the kernel version, but the change was never made to conditionally move away from the EXTRA_CFLAGS.
Now that the older way no longer exists, always use ccflags-y.
Resolves: #76