Skip to content

feat: allow ts_project to point to the eslint config #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: allow ts_project to point to the eslint config #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29a1e08
feat: allow ts_project to point to the eslint config
alexeagle Aug 19, 2025
d329059
chore: docgen
alexeagle Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions docs/rules.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions ts/private/ts_lib.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ https://docs.aspect.build/rulesets/aspect_rules_js/docs/js_library#deps for more
mandatory = True,
allow_single_file = [".json"],
),
"eslintconfig": attr.label(
doc = """.eslintrc file, or other filenames accepted by ESLint.
see https://eslint.org/docs/latest/use/configure/configuration-files
Note, this is unused in rules_ts, but exists to allow the information to propagate through the dependency graph.
For example, it can be used by the eslint aspect in Aspect's rules_lint.
""",
allow_single_file = True,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note, it should be possible to pass a js_library target here, so that an eslint config can bring any dependencies it requires

),
"isolated_typecheck": attr.bool(
doc = """\
Whether type-checking should be a separate action.
Expand Down