Skip to content

Conversation

alexeagle
Copy link
Member

ESLint flat config is not ergonomic in a monorepo. Many projects would prefer to have the eslint config locally, for example one-per-package.json

See aspect-build/rules_lint@main...eslint_no_flat for how this may be used.

FYI @jfirebaugh @walkerburgin

ESLint flat config is not ergonomic in a monorepo.
Many projects would prefer to have the eslint config locally, for example one-per-package.json

See aspect-build/rules_lint@main...eslint_no_flat for how this may be used.
@alexeagle alexeagle requested a review from jbedard August 19, 2025 15:19
Note, this is unused in rules_ts, but exists to allow the information to propagate through the dependency graph.
For example, it can be used by the eslint aspect in Aspect's rules_lint.
""",
allow_single_file = True,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note, it should be possible to pass a js_library target here, so that an eslint config can bring any dependencies it requires

Copy link

aspect-workflows bot commented Aug 19, 2025

Test (Bazel 6.x) (Test)

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.


Test (Bazel 7.x) (Test)

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.


Test (Bazel 8.x) (Test)

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.


Bazel-7

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.


Bazel-8

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 20ms.


Bazel-6

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 230ms.


Bazel-7

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 341ms.


Bazel-8

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 334ms.


Bazel-7

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 71ms.


Bazel-8

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 84ms.


Bazel-6

e2e/test

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.


Bazel-7

e2e/test

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.


Bazel-8

e2e/test

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.


Bazel-6

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 267ms.


Bazel-7

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 325ms.


Bazel-8

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 401ms.


Buildifier      Format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant