refactor: align pnpm package store with lockfile #2177

jbedard · 2025-04-21T17:27:06Z

Fixes issues such as:

npm package conflicting actions error #2071
various warnings outputted when multiple versions exist such as vendored + non-vendored in rules_js tests

Changes are visible to end-users: yes/no

Searched for relevant documentation and updated as needed: yes/no
Breaking change (forces users to change their own code or config): yes/no
Suggested release notes appear below: yes/no

Test plan

Covered by existing test cases
New test cases added
Manual testing; please provide instructions so we can reproduce:

aspect-workflows · 2025-04-21T17:27:57Z

Test

32 test targets passed

Targets

//:npm_link_targets_test [k8-fastbuild]                                                        86ms
//examples/js_binary:aspect_bin_a_test [k8-fastbuild]                                          122ms
//examples/js_lib_pkg/b:test [k8-fastbuild]                                                    132ms
//examples/linked_consumer:pkg [k8-fastbuild]                                                  151ms
//examples/macro:test [k8-fastbuild]                                                           1s
//examples/npm_deps:test10 [k8-fastbuild]                                                      224ms
//examples/npm_deps:test7 [k8-fastbuild]                                                       169ms
//examples/npm_deps:test8 [k8-fastbuild]                                                       84ms
//examples/npm_deps:test9 [k8-fastbuild]                                                       183ms
//examples/npm_deps:test_peer [k8-fastbuild]                                                   259ms
//examples/npm_deps:test_uvu_version [k8-fastbuild]                                            231ms
//examples/webpack_cli:test [k8-fastbuild]                                                     1s
//js/private/coverage:coverage_checked_test [k8-fastbuild]                                     40ms
//js/private/test/image:assert_custom_layers_nomatch_test_node_modules_test [k8-fastbuild]     80ms
//js/private/test/image:assert_custom_layers_nomatch_test_package_store_1p_test [k8-fastbuild] 67ms
//js/private/test/image:assert_custom_owner_test_node_modules_test [k8-fastbuild]              94ms
//js/private/test/image:assert_custom_owner_test_package_store_1p_test [k8-fastbuild]          38ms
//js/private/test/image:assert_default_test_node_modules_test [k8-fastbuild]                   72ms
//js/private/test/image:assert_default_test_package_store_1p_test [k8-fastbuild]               77ms
//js/private/test/image:assert_regex_edge_cases_test_node_modules_test [k8-fastbuild]          76ms
//js/private/test/image:assert_regex_edge_cases_test_package_store_1p_test [k8-fastbuild]      93ms
//js/private/test/image:checksum_test_test_test [k8-fastbuild]                                 67ms
//js/private/worker:worker_checked_test [k8-fastbuild]                                         73ms
//npm/private/test:node_modules_test [k8-fastbuild]                                            58ms
//npm/private/test:test_utils_test_8 [k8-fastbuild]                                            128ms
//npm/private/test:write_npm_translate_lock_0_test [k8-fastbuild]                              128ms
//npm/private/test:write_npm_translate_lock_1_test [k8-fastbuild]                              104ms
//npm/private/test:write_npm_translate_lock_2_test [k8-fastbuild]                              151ms
//npm/private/test:write_npm_translate_lock_3_test [k8-fastbuild]                              120ms
//npm/private/test:write_npm_translate_lock_5_test [k8-fastbuild]                              114ms
//npm/private:_test_gendocs_0_0 [k8-fastbuild]                                                 51ms
//npm/private:_test_gendocs_0_1 [k8-fastbuild]                                                 49ms

Total test execution time was 6s. 193 tests (85.8%) were fully cached saving 24s.

Test

e2e/bzlmod

1 test target passed

Targets

//:test [k8-fastbuild]                                                                         230ms

Total test execution time was 230ms. 4 tests (80.0%) were fully cached saving 310ms.

Test

e2e/gyp_no_install_script

2 test targets passed

Targets

//:test [k8-fastbuild]                                                                         101ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                         66ms

Test

e2e/js_image_oci

⚠️ Buildkite build #8709 failed.

//:.aspect_rules_js/node_modules/[email protected]/pkg failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/[email protected]/pkg:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/utils.bzl", line
51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/[email protected]/pkg:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/utils.bzl", line
51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

//:.aspect_rules_js/node_modules/[email protected]/ref failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/[email protected]/ref:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/utils.bzl", line
51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/[email protected]/ref:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/utils.bzl", line
51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

//:.aspect_rules_js/node_modules/[email protected]/pkg failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/[email protected]/pkg:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_js_image_oci/external/aspect_rules_js~/npm/private/utils.bzl", line
51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

15 other actions failed to build.

💡 To reproduce the build failures, run

bazel build //:.aspect_rules_js/node_modules/[email protected]/pkg //:.aspect_rules_js/node_modules/[email protected]/ref //:.aspect_rules_js/node_modules/[email protected]/pkg

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 699ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 822ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 255ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 97ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 450ms.

Test

e2e/pnpm_lockfiles

⚠️ Buildkite build #8709 failed.

Test

e2e/pnpm_workspace

⚠️ Buildkite build #8709 failed.

//:.aspect_rules_js/node_modules/@[email protected]/pkg failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/@[email protected]/pkg:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/utils.bzl",
line 51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

//:.aspect_rules_js/node_modules/@[email protected]/ref failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/@[email protected]/ref:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/utils.bzl",
line 51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

//:.aspect_rules_js/node_modules/@[email protected]_@[email protected]/ref failed to build

in npm_package_store_internal rule
//:.aspect_rules_js/node_modules/@[email protected]_@[email protected]/ref:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/utils.bzl",
line 51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

//:.aspect_rules_js/node_modules/@[email protected]/pkg failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/@[email protected]/pkg:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/utils.bzl",
line 51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

//:.aspect_rules_js/node_modules/@[email protected]/pkg_pre_lc_lite failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/@[email protected]/pkg_pre_lc_lite:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_pnpm_workspace/external/aspect_rules_js~/npm/private/utils.bzl",
line 51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

8 other actions failed to build.

💡 To reproduce the build failures, run

bazel build //:.aspect_rules_js/node_modules/@[email protected]/pkg //:.aspect_rules_js/node_modules/@[email protected]/ref //:.aspect_rules_js/node_modules/@[email protected]_@[email protected]/ref //:.aspect_rules_js/node_modules/@[email protected]/pkg //:.aspect_rules_js/node_modules/@[email protected]/pkg_pre_lc_lite

Test

e2e/pnpm_workspace_rerooted

8 test targets passed

Targets

//:repos_test [k8-fastbuild]                                                                   120ms
//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                  157ms
//app/a:npm_link_targets_test [k8-fastbuild]                                                   164ms
//app/a:test [k8-fastbuild]                                                                    395ms
//app/b:test [k8-fastbuild]                                                                    212ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                  75ms
//app/c:test [k8-fastbuild]                                                                    262ms
//app/d:test [k8-fastbuild]                                                                    375ms

Total test execution time was 2s. 7 tests (46.7%) were fully cached saving 900ms.

Test

e2e/repo_mapping

⚠️ Buildkite build #8709 failed.

//:.aspect_rules_js/node_modules/npm__uvu__0.5.6 failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/npm__uvu__0.5.6:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_repo_mapping/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_repo_mapping/external/aspect_rules_js~/npm/private/utils.bzl", line
51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

//:.aspect_rules_js/node_modules/[email protected]/pkg failed to build

in npm_package_store_internal rule //:.aspect_rules_js/node_modules/[email protected]/pkg:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_repo_mapping/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 190, column 50, in _npm_package_store_impl
		package_store_name = utils.package_store_name(ctx.attr.key)
	File "/mnt/ephemeral/output/rules_js/e2e_repo_mapping/external/aspect_rules_js~/npm/private/utils.bzl", line
51, column 5, in _package_store_name
		return result
Error: _package_store_name() missing 1 required positional argument: pnpm_version

💡 To reproduce the build failures, run

bazel build //:.aspect_rules_js/node_modules/npm__uvu__0.5.6 //:.aspect_rules_js/node_modules/[email protected]/pkg

Test

e2e/rules_foo

2 test targets passed

Targets

//foo:run_main_test [k8-fastbuild]                                                             30ms
//foo:test [k8-fastbuild]                                                                      146ms

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 80ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.

Buildifier

Format

jbedard force-pushed the pnpm-cleanup branch from 26454ef to 3ceac26 Compare April 21, 2025 17:57

jbedard mentioned this pull request Apr 21, 2025

fix: pnpm v9 peer deps with workspace/link: deps #2179

Merged

jbedard force-pushed the pnpm-cleanup branch 3 times, most recently from f745904 to 0b1f0b6 Compare April 22, 2025 01:42

jbedard mentioned this pull request Apr 22, 2025

test: aliases to local link: packages #2183

Merged

jbedard force-pushed the pnpm-cleanup branch 8 times, most recently from f7bed30 to 431fcc4 Compare April 24, 2025 22:23

jbedard mentioned this pull request Apr 24, 2025

refactor: order generated packages in npm_translate_lock #2176

Closed

jbedard force-pushed the pnpm-cleanup branch 3 times, most recently from dc0ea93 to 77328f0 Compare May 1, 2025 00:43

This was referenced May 1, 2025

rules_js v3 BREAKING CHANGES #1993

Open

fix: pnpm v9 url version specifiers without resolved semver #2209

Merged

fix(npm): use known version numbers when available for linked file: packages #2029

Closed

jbedard force-pushed the pnpm-cleanup branch from 77328f0 to 102e08b Compare May 1, 2025 01:22

jbedard mentioned this pull request Jun 25, 2025

feat: support pnpm v10 #2101

Merged

jbedard added 2 commits June 24, 2025 20:31

BROKEN-test: peer dependencies between workspace projects

87b71b3

refactor: align pnpm package store with lockfile

d3bbeac

jbedard force-pushed the pnpm-cleanup branch from 102e08b to d3bbeac Compare June 25, 2025 03:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: align pnpm package store with lockfile #2177

refactor: align pnpm package store with lockfile #2177

Uh oh!

jbedard commented Apr 21, 2025 •

edited

Loading

Uh oh!

aspect-workflows bot commented Apr 21, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

refactor: align pnpm package store with lockfile #2177

Are you sure you want to change the base?

refactor: align pnpm package store with lockfile #2177

Uh oh!

Conversation

jbedard commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes are visible to end-users: yes/no

Test plan

Uh oh!

aspect-workflows bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

e2e/bzlmod

e2e/gyp_no_install_script

e2e/js_image_oci

e2e/npm_link_package

e2e/npm_link_package-esm

e2e/npm_translate_lock

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_package_lock

e2e/npm_translate_yarn_lock

e2e/package_json_module

e2e/pnpm_lockfiles

e2e/pnpm_workspace

e2e/pnpm_workspace_rerooted

e2e/repo_mapping

e2e/rules_foo

e2e/runfiles

e2e/vendored_node

Buildifier

Format

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jbedard commented Apr 21, 2025 •

edited

Loading

aspect-workflows bot commented Apr 21, 2025 •

edited

Loading