fix(npm): use known version numbers when available for linked file: packages

[jbedard]

…

---

Changes are visible to end-users: yes/no

• Searched for relevant documentation and updated as needed: yes/no
• Breaking change (forces users to change their own code or config): yes/no
• Suggested release notes appear below: yes/no

Test plan

• Covered by existing test cases
• New test cases added
• Manual testing; please provide instructions so we can reproduce:

[aspect-workflows]

Test

22 test targets passed

Targets

//examples/js_lib_pkg/b:test [k8-fastbuild]                                                    137ms
//examples/linked_consumer:pkg [k8-fastbuild]                                                  175ms
//examples/npm_deps:test10 [k8-fastbuild]                                                      175ms
//examples/npm_deps:test7 [k8-fastbuild]                                                       1s
//examples/npm_deps:test9 [k8-fastbuild]                                                       179ms
//examples/npm_deps:test_uvu_version [k8-fastbuild]                                            1s
//js/private/test/image:assert_custom_layers_nomatch_test_node_modules_test [k8-fastbuild]     42ms
//js/private/test/image:assert_custom_layers_nomatch_test_package_store_1p_test [k8-fastbuild] 48ms
//js/private/test/image:assert_custom_layers_nomatch_test_package_store_3p_test [k8-fastbuild] 45ms
//js/private/test/image:assert_custom_owner_test_node_modules_test [k8-fastbuild]              46ms
//js/private/test/image:assert_custom_owner_test_package_store_1p_test [k8-fastbuild]          43ms
//js/private/test/image:assert_custom_owner_test_package_store_3p_test [k8-fastbuild]          45ms
//js/private/test/image:assert_default_test_node_modules_test [k8-fastbuild]                   45ms
//js/private/test/image:assert_default_test_package_store_1p_test [k8-fastbuild]               46ms
//js/private/test/image:assert_default_test_package_store_3p_test [k8-fastbuild]               45ms
//js/private/test/image:assert_regex_edge_cases_test_node_modules_test [k8-fastbuild]          44ms
//js/private/test/image:assert_regex_edge_cases_test_package_store_1p_test [k8-fastbuild]      31ms
//js/private/test/image:assert_regex_edge_cases_test_package_store_3p_test [k8-fastbuild]      49ms
//js/private/test/image:checksum_test_test_test [k8-fastbuild]                                 45ms
//npm/private/test:write_npm_translate_lock_0_test [k8-fastbuild]                              47ms
//npm/private:_test_gendocs_0_0 [k8-fastbuild]                                                 35ms
//npm/private:_test_gendocs_0_1 [k8-fastbuild]                                                 37ms

Total test execution time was 4s. 203 tests (90.2%) were fully cached saving 30s.

---

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.

---

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 232ms.

---

Test

e2e/js_image_oci

1 test target passed

Targets

//src:image_test [k8-fastbuild]                                                                7s

---

Test

e2e/npm_link_package

⚠️ Buildkite build #8369 failed.

//:.aspect_rules_js/node_modules/@e2e/lib failed to build

in npm_package_store rule //:.aspect_rules_js/node_modules/@e2e/lib:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_npm_link_package/external/aspect_rules_js/npm/private/npm_package_store.bzl",
line 168, column 21, in _npm_package_store_impl
		fail(msg)
Error in fail: Expected package+version to be specified in '@@//:.aspect_rules_js/node_modules/@e2e/lib' when
src '@@//lib:lib_pkg' provides a JsInfo

💡 To reproduce the build failures, run

bazel build //:.aspect_rules_js/node_modules/@e2e/lib

---

Test

e2e/npm_link_package-esm

⚠️ Buildkite build #8369 failed.

//:.aspect_rules_js/node_modules/@e2e/lib failed to build

in npm_package_store rule //:.aspect_rules_js/node_modules/@e2e/lib:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_npm_link_package-esm/external/aspect_rules_js/npm/private/npm_package_store.bzl",
line 168, column 21, in _npm_package_store_impl
		fail(msg)
Error in fail: Expected package+version to be specified in '@@//:.aspect_rules_js/node_modules/@e2e/lib' when
src '@@//lib:lib_pkg' provides a JsInfo

💡 To reproduce the build failures, run

bazel build //:.aspect_rules_js/node_modules/@e2e/lib

---

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.

---

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

---

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 603ms.

---

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 98ms.

---

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

---

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

---

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 253ms.

---

Test

e2e/pnpm_lockfiles

⚠️ Buildkite build #8369 failed.

//v54:.aspect_rules_js/node_modules/[email protected]/pkg failed to build

in deps attribute of npm_package_store_internal rule //v54:.aspect_rules_js/node_modules/[email protected]/pkg:
target '//v54:.aspect_rules_js/node_modules/is-number@file++..+vendored+is-number/ref' does not exist. Since
this rule was created by the macro 'lockfile_test', the error might have been caused by the macro
implementation

//v90:.aspect_rules_js/node_modules/@scoped+c@file++..+projects+c failed to build

in deps attribute of npm_package_store rule
//v90:.aspect_rules_js/node_modules/@scoped+c@file++..+projects+c: target
'//v90:.aspect_rules_js/node_modules/@scoped+a@link++..+a' does not exist. Since this rule was created by the
macro 'lockfile_test', the error might have been caused by the macro implementation

//v54:.aspect_rules_js/node_modules/[email protected]/pkg failed to build

in deps attribute of npm_package_store_internal rule //v54:.aspect_rules_js/node_modules/[email protected]/pkg:
target '//v54:.aspect_rules_js/node_modules/is-number@file++..+vendored+is-number/ref' does not exist. Since
this rule was created by the macro 'lockfile_test', the error might have been caused by the macro
implementation

//v61:.aspect_rules_js/node_modules/[email protected]/pkg failed to build

in deps attribute of npm_package_store_internal rule //v61:.aspect_rules_js/node_modules/[email protected]/pkg:
target '//v61:.aspect_rules_js/node_modules/is-number@file++..+vendored+is-number/ref' does not exist. Since
this rule was created by the macro 'lockfile_test', the error might have been caused by the macro
implementation

//v61:.aspect_rules_js/node_modules/[email protected]/pkg failed to build

in deps attribute of npm_package_store_internal rule //v61:.aspect_rules_js/node_modules/[email protected]/pkg:
target '//v61:.aspect_rules_js/node_modules/is-number@file++..+vendored+is-number/ref' does not exist. Since
this rule was created by the macro 'lockfile_test', the error might have been caused by the macro
implementation

14 other actions failed to build.

Failed tests (2)

//v60:repos_0_test [k8-fastbuild]🔗
//v61:repos_0_test [k8-fastbuild]🔗

💡 To reproduce the build failures, run

bazel build //v54:.aspect_rules_js/node_modules/[email protected]/pkg //v90:.aspect_rules_js/node_modules/@scoped+c@file++..+projects+c //v54:.aspect_rules_js/node_modules/[email protected]/pkg //v61:.aspect_rules_js/node_modules/[email protected]/pkg //v61:.aspect_rules_js/node_modules/[email protected]/pkg

💡 To reproduce the test failures, run

bazel test //v60:repos_0_test //v61:repos_0_test

---

Test

e2e/pnpm_workspace

⚠️ Buildkite build #8369 failed.

Failed tests (1)

//:repos_test [k8-fastbuild]🔗

💡 To reproduce the test failures, run

bazel test //:repos_test

---

Test

e2e/pnpm_workspace_rerooted

⚠️ Buildkite build #8369 failed.

Failed tests (1)

//:repos_test [k8-fastbuild]🔗

💡 To reproduce the test failures, run

bazel test //:repos_test

---

Test

e2e/repo_mapping

⚠️ Buildkite build #8369 failed.

//:.aspect_rules_js/node_modules/@e2e/lib failed to build

in npm_package_store rule //:.aspect_rules_js/node_modules/@e2e/lib:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_repo_mapping/external/aspect_rules_js~/npm/private/npm_package_store.bzl",
line 168, column 21, in _npm_package_store_impl
		fail(msg)
Error in fail: Expected package+version to be specified in '@@//:.aspect_rules_js/node_modules/@e2e/lib' when
src '@@//lib:lib_pkg' provides a JsInfo

💡 To reproduce the build failures, run

bazel build //:.aspect_rules_js/node_modules/@e2e/lib

---

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 187ms.

---

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 173ms.

---

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.

---

Buildifier      Format

[jbedard]

will be part of a bigger change such as #2177