fix: remove lock acquisition in ClusterCache.GetAPIResources() #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 54.60% 54.63% +0.03%
==========================================
Files 41 41
Lines 4641 4638 -3
==========================================
Hits 2534 2534
+ Misses 1911 1908 -3
Partials 196 196
☔ View full report in Codecov by Sentry. |
Signed-off-by: Jesse Suen <[email protected]>
jessesuen
force-pushed
the
fix/api-resources-lock-contention
branch
from
fc49f37 to
a1da0c1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
alexmt
approved these changes
Oct 11, 2023
gdsoumya
approved these changes
Oct 11, 2023
ishitasequeira
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses argoproj/argo-cd#15850.
The lock we were acquiring in GetAPIResources() was unnecessary and caused Argo CD app reconciliation to spend extra time waiting to get API resource information.