fix: remove lock acquisition in ClusterCache.GetAPIResources()

Signed-off-by: Jesse Suen <[email protected]>

pkg/cache/cluster.go

@@ -300,10 +300,10 @@ func (c *clusterCache) GetServerVersion() string {
 }
 
 // GetAPIResources returns information about observed API resources
+// This method is called frequently during reconciliation to pass API resource info to `helm template`
 func (c *clusterCache) GetAPIResources() []kube.APIResourceInfo {
-	c.lock.RLock()
-	defer c.lock.RUnlock()
-
+	// c.lock is unnecessary to acquire when returning c.apiResources since lists are safe to access
+	// concurrently and we anyway don't provide any consistency guarantees if updated while iterated
 	return c.apiResources
 }