Skip to content

Fix DigitalOutputs writeAll function logical operator #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix DigitalOutputs writeAll function logical operator #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DigitalOutputsClass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ void DigitalOutputsClass::write(uint8_t channel, PinStatus val) {

void DigitalOutputsClass::writeAll(uint8_t val_mask) {
for (uint8_t ch = 0; ch < 8; ch++) {
if (val_mask && (1 << ch)) {
if (val_mask & (1 << ch)) {
write(ch, HIGH);
} else {
write(ch, LOW);
Expand All @@ -94,4 +94,4 @@ void DigitalOutputsClass::_setAutoRetryMode() {
}

DigitalOutputsClass MachineControl_DigitalOutputs;
/**** END OF FILE ****/
/**** END OF FILE ****/
Loading